Merged
Conversation
Owner
|
@matsl , let's discuss and finalize tomorrow. I'd like to understand the trade-offs of switching from kbd-key to execute-kbd-macro. |
Collaborator
Author
We did not discuss this in our last Talk. My thinking is like this:
Things I feel are better with execute-kbd-macro:
|
* test/hyrolo-tests.el: Prefix all tests with hyrolo-tests. Use
execute-kbd-macro instead of calling hact.
(hyrolo-tests--add-items-interactive):
(hyrolo-tests--hyrolo-grep-interactive): Add new separate test for
interactive call.
(hyrolo-tests--sort-test, hyrolo-tests--fgrep-find-all-types-of-files):
Modify test to do both interactive and non-interactive call.
(hyrolo-tests--fgrep-find-all-types-of-files): Use hy-delete-files-and-buffers.
(hyrolo-tests--get-file-list): Use hy-delete-file-and-buffer.
(hyrolo-tests--hyrolo-reveal-mode): Remove non-interactive guard.
(hyrolo-tests--sort): Remove name suffix tests.
ae79768 to
5d4ccee
Compare
rswgnu
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update and refactor hyrolo-tests.el
execute-kbd-macro instead of calling hact.
(hyrolo-tests--add-items-interactive):
(hyrolo-tests--hyrolo-grep-interactive): Add new separate test for
interactive call.
(hyrolo-tests--sort-test, hyrolo-tests--fgrep-find-all-types-of-files):
Modify test to do both interactive and non-interactive call.
(hyrolo-tests--fgrep-find-all-types-of-files): Use hy-delete-files-and-buffers.
(hyrolo-tests--get-file-list): Use hy-delete-file-and-buffer.
(hyrolo-tests--hyrolo-reveal-mode): Remove non-interactive guard.
(hyrolo-tests--sort): Remove name suffix tests.
Why
While doing updates for interactive tests a set of small improvements
where found. This PR applies the updates into one PR with one commit.