Add test of interactive calls to existing hyrolo tests#900
Closed
Add test of interactive calls to existing hyrolo tests#900
Conversation
* test/hyrolo-tests.el (hyrolo-add-items-interactive):
(hyrolo-tests--hyrolo-grep-interactive): Add new separate test for
interactive call.
(hyrolo-sort-test, hyrolo-fgrep-find-all-types-of-files): Modify test to
do both interactive and non-interactive call.
rswgnu
requested changes
Mar 14, 2026
| @@ -1,3 +1,11 @@ | |||
| 2026-03-13 Mats Lidell <matsl@gnu.org> | |||
|
|
|||
| * test/hyrolo-tests.el (hyrolo-add-items-interactive): | |||
Owner
There was a problem hiding this comment.
Use hyrolo-tests-- prefix consistently for all test defined herein.
Collaborator
Author
There was a problem hiding this comment.
Do you think we should rename all tests using the prefix or only the tests we touch as we do updates?
Collaborator
Author
Owner
|
Just do it as you update things.-- BobOn Mar 14, 2026, at 10:17 AM, Mats Lidell ***@***.***> wrote:
@matsl commented on this pull request.
In ChangeLog:
@@ -1,3 +1,11 @@
+2026-03-13 Mats Lidell ***@***.***>
+
+* test/hyrolo-tests.el (hyrolo-add-items-interactive):
@rswgnu I added all refactoring together with this PR here into #901. So setting this as a draft for now. If you prefer to take i piece by piece, commit by commit, I can activate this again.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Collaborator
Author
OK. Lets discuss tomorrow about #901 where I put everything together. Used my time awake before you got a chance to reply. Actually doing most of those changes were simple replacements so did not take much time. |
Owner
|
Now you can close this PR because 901 supeceded it, right? |
Collaborator
Author
Yes. It was the first part of a multiple step change which all went into #901. Thanks for accepting that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add test of interactive calls to existing hyrolo tests
(hyrolo-tests--hyrolo-grep-interactive): Add new separate test for
interactive call.
(hyrolo-sort-test, hyrolo-fgrep-find-all-types-of-files): Modify test to
do both interactive and non-interactive call.
Why
There are code paths that are only triggered through interactive
calls so for good coverage we need to do that as well.
Note
There are unfortunately many hyrolo functions, with and without
interactive specifications, that have no tests today. This PR only
scratches the surface. So there is more work to be done for getting
better test coverage of hyrolo.