Skip to content

Add test of interactive calls to existing hyrolo tests #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matsl wants to merge 2 commits into from
Closed

Add test of interactive calls to existing hyrolo tests #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c6448
Add test of interactive calls to existing hyrolo tests
matsl Mar 13, 2026
424f215
Use hy-test-helpers:ert-simulate-keys
matsl Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
2026-03-13 Mats Lidell <matsl@gnu.org>

* test/hyrolo-tests.el (hyrolo-add-items-interactive):
Copy link
Owner

@rswgnu rswgnu Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use hyrolo-tests-- prefix consistently for all test defined herein.

Copy link
Collaborator Author

@matsl matsl Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should rename all tests using the prefix or only the tests we touch as we do updates?

Copy link
Collaborator Author

@matsl matsl Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rswgnu I added all refactoring together with this PR here into #901. So setting this as a draft for now. If you prefer to take i piece by piece, commit by commit, I can activate this again.

(hyrolo-tests--hyrolo-grep-interactive): Add new separate test for
interactive call.
(hyrolo-sort-test, hyrolo-fgrep-find-all-types-of-files): Modify test to
do both interactive and non-interactive call.

2026-03-11 Bob Weiner <rsw@gnu.org>

* hsys-org.el (hsys-org-link-at-p): Clarify doc string with regard to
Expand Down
107 changes: 79 additions & 28 deletions test/hyrolo-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
;;; Code:

(require 'ert)
(require 'ert-x)
(require 'hact)
(require 'hyrolo)
(require 'hyrolo-demo)
Expand All @@ -45,6 +46,28 @@
(should (looking-at-p "\\*\\*\\* c")))
(hy-delete-file-and-buffer hyrolo-file))))

(ert-deftest hyrolo-add-items-interactive ()
"`hyrolo-add` can add items when called interactively."
(let ((hyrolo-file (make-temp-file "hypb" nil ".otl")))
(unwind-protect
(let ((hyrolo-file-list (list hyrolo-file)))
(find-file (car (hyrolo-get-file-list)))
(insert "===\nHdr\n===\n")
(goto-char (point-min))
(should (looking-at "==="))
(hy-test-helpers:ert-simulate-keys "item\n"
(call-interactively #'hyrolo-add))
(beginning-of-line)
(should (looking-at-p "\\* item\n"))
;; hyrolo-add in mail buffer
(with-mock
(mock (hyrolo-name-and-email) => (list "first, last" "email"))
(hy-test-helpers:ert-simulate-keys "\n" ;; Confirm proposed name
(call-interactively #'hyrolo-add))
(beginning-of-line)
(should (looking-at-p "\\* first, last\t\t<email>\n"))))
(hy-delete-file-and-buffer hyrolo-file))))

(ert-deftest hyrolo-demo-search-work ()
"Use demo example and search for work should match work."
(unwind-protect
Expand Down Expand Up @@ -195,29 +218,34 @@ and {b} the previous same level cell."
(let ((hyrolo-file-list (list hyrolo-file))
(hyrolo-date-format "%m/%d/%Y"))
(hyrolo-find-file (car (hyrolo-get-file-list)))
(insert "===\nHdr\n===\n")
(goto-char (point-min))
(should (looking-at "==="))
(hyrolo-add "c")
(hyrolo-add "b")
(hyrolo-add "a")
(hyrolo-add "b/d")

;; Verify insertion order and following date on separate line
(goto-char (point-min))
(should (looking-at "==="))
(dolist (insertion-order '("a" "b" "d" "c"))
(goto-char (1+ (should (search-forward insertion-order))))
(should (looking-at-p "^\t[0-9/]+$")))

(hyrolo-sort)

;; Verify sorted order and following date on separate line
(goto-char (point-min))
(should (looking-at "==="))
(dolist (sorted-order '("a" "b" "d" "c"))
(goto-char (1+ (should (search-forward sorted-order))))
(should (looking-at-p "^\t[0-9/]+$"))))
(dolist (v '(:interactive nil))
(erase-buffer)
(insert "===\nHdr\n===\n")
(goto-char (point-min))
(should (looking-at "==="))
(hyrolo-add "c")
(hyrolo-add "b")
(hyrolo-add "a")
(hyrolo-add "b/d")

;; Verify insertion order and following date on separate line
(goto-char (point-min))
(should (looking-at "==="))
(dolist (insertion-order '("a" "b" "d" "c"))
(goto-char (1+ (should (search-forward insertion-order))))
(should (looking-at-p "^\t[0-9/]+$")))

(if (eq v :interactive)
(hy-test-helpers:ert-simulate-keys "\n" ;; Confirm proposed name
(call-interactively #'hyrolo-sort))
(hyrolo-sort))

;; Verify sorted order and following date on separate line
(goto-char (point-min))
(should (looking-at "==="))
(dolist (sorted-order '("a" "b" "d" "c"))
(goto-char (1+ (should (search-forward sorted-order))))
(should (looking-at-p "^\t[0-9/]+$")))))
(hy-delete-file-and-buffer hyrolo-file))))

(ert-deftest hyrolo-sort-records-at-different-levels ()
Expand Down Expand Up @@ -269,11 +297,15 @@ and {b} the previous same level cell."
(hyrolo-file-list (list folder)))
(unwind-protect
(progn
(hyrolo-fgrep "string")
(should (string= (buffer-name) hyrolo-display-buffer))
(should (= (how-many "@loc>") 4))
(dolist (f (list org-file kotl-file md-file outl-file))
(should (= (how-many (concat "@loc> \"" f "\"")) 1))))
(dolist (v '(:interactive nil))
(if (eq v :interactive)
(hy-test-helpers:ert-simulate-keys "string\n"
(call-interactively #'hyrolo-fgrep))
(hyrolo-fgrep "string"))
(should (string= (buffer-name) hyrolo-display-buffer))
(should (= (how-many "@loc>") 4))
(dolist (f (list org-file kotl-file md-file outl-file))
(should (= (how-many (concat "@loc> \"" f "\"")) 1)))))
(dolist (f (list org-file kotl-file md-file outl-file))
(hy-delete-file-and-buffer f))
(kill-buffer hyrolo-display-buffer)
Expand Down Expand Up @@ -523,6 +555,25 @@ Example:
heading-prefix-char heading (1+ section) body depth))))
result))

(ert-deftest hyrolo-tests--hyrolo-grep-interactive ()
"Verify `hyrolo-grep' works when called interactively.
This just verifies it looks good when called interactively. Other tests
below verifies all the details."
(let* ((org-file (make-temp-file "hypb" nil ".org"
(hyrolo-tests--gen-outline ?* "heading" 2 "body" 2)))
(hyrolo-file-list (list org-file)))
(unwind-protect
(progn
(hy-test-helpers:ert-simulate-keys "body\n"
(call-interactively #'hyrolo-grep))
(should (string= hyrolo-display-buffer (buffer-name)))

(should (looking-at-p "==="))
(execute-kbd-macro (kbd "n"))
(should (looking-at-p "^\\* heading 1")))
(kill-buffer hyrolo-display-buffer)
(hy-delete-files-and-buffers hyrolo-file-list))))

(ert-deftest hyrolo-tests--outline-next-visible-heading ()
"Verify movement to next visible heading."
(let* ((org-file (make-temp-file "hypb" nil ".org"
Expand Down
Loading