Added velocity limiting to the mecanum controller. (backport #2313)#2363
Merged
Conversation
(cherry picked from commit be5379a) # Conflicts: # mecanum_drive_controller/CMakeLists.txt # mecanum_drive_controller/include/mecanum_drive_controller/mecanum_drive_controller.hpp # mecanum_drive_controller/src/mecanum_drive_controller.cpp # mecanum_drive_controller/src/mecanum_drive_controller.yaml # mecanum_drive_controller/test/test_mecanum_drive_controller.cpp
Contributor
Author
|
Cherry-pick of be5379a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## kilted #2363 +/- ##
==========================================
+ Coverage 85.85% 85.99% +0.14%
==========================================
Files 152 152
Lines 15113 15405 +292
Branches 1296 1317 +21
==========================================
+ Hits 12975 13248 +273
- Misses 1682 1699 +17
- Partials 456 458 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added velocity limiting to linear x,y direction and angular yaw. Also, added tests to verify them.
Fixes # (issue)
Is this user-facing behavior change?
Users can set velocity limits but if they are not set it will not change behaviors.
Did you use Generative AI?
No.
Additional Information
TODOs
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)This is an automatic backport of pull request #2313 done by [Mergify](https://mergify.com).