Skip to content

chore: remove system and update owners in catalog-info.yaml #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hopehadfield wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove system and update owners in catalog-info.yaml #2427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
github.com/team-slug: redhat-developer/rhdh-plugins-contributers
#sonarqube.org/project-key: redhat-developer_rhdh-plugins
spec:
type: backstage-plugin-repository
type: repository
lifecycle: active
owner: rhdh-team
system: rhdh
3 changes: 1 addition & 2 deletions workspaces/adoption-insights/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ metadata:
# backstage.io/techdocs-ref: dir:.
spec:
type: backstage-plugin
owner: john@example.com
lifecycle: active
system: rhdh
owner: rhdh-ui-team
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/ai-integrations/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ metadata:
# backstage.io/techdocs-ref: dir:.
spec:
type: backstage-plugin
owner: jcollier@redhat.com
lifecycle: active
system: rhdh
owner: rhdh-team
subcomponentOf: rhdh-plugins
1 change: 0 additions & 1 deletion workspaces/bulk-import/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,4 @@ spec:
type: backstage-plugin
owner: rhdh-team
lifecycle: active
system: rhdh
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/extensions/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@ metadata:
spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-team
system: rhdh
owner: rhdh-ui-team
subcomponentOf: rhdh-plugins
1 change: 0 additions & 1 deletion workspaces/global-floating-action-button/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-ui-team
system: rhdh
subcomponentOf: rhdh-plugins
1 change: 0 additions & 1 deletion workspaces/global-header/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-ui-team
system: rhdh
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/homepage/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@ metadata:
spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-team
system: rhdh
owner: rhdh-ui-team
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/lightspeed/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ metadata:
spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-team
system: rhdh
owner: rhdh-ui-team
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/mcp-integrations/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ metadata:
# backstage.io/techdocs-ref: dir:.
spec:
type: backstage-plugin
owner: john@example.com
owner: rhdh-ai
Copy link

@rhdh-qodo-merge rhdh-qodo-merge bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Undefined owner group 🐞 Bug ✓ Correctness

workspaces/mcp-integrations/catalog-info.yaml now sets spec.owner: rhdh-ai, but no Group
entity named rhdh-ai exists in the repo’s team definitions, so ownership relations/links (and any
ownership-based workflows) will be broken for this component.
Agent Prompt 
### Issue description
`workspaces/mcp-integrations/catalog-info.yaml` references an owner group (`rhdh-ai`) that is not defined in the repository’s group catalog descriptors, which breaks ownership relations.

### Issue Context
The repo includes `catalog-info-teams.yaml` with the defined team groups used in other catalog entries. `rhdh-ai` is not present there.

### Fix Focus Areas
- workspaces/mcp-integrations/catalog-info.yaml[10-14]
- catalog-info-teams.yaml[4-42]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Copy link
Contributor

@gabemontero gabemontero Mar 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so @hopehadfield you used rhdh-team for the ai-integrations change .... unless @johnmcollier disagrees, I would suggest that whichever team is used for ai-integrations can be used for mcp-integrations

Copy link

@rhdh-qodo-merge rhdh-qodo-merge bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Implementation 🛠️

Implementation: Update the component owner to an existing Group entity defined in the repository so ownership relations resolve correctly.

Suggested change
owner: rhdh-ai
owner: rhdh-team
📄 References

See review comment here

Copy link
Member Author

@hopehadfield hopehadfield Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabemontero I was working based off the CODEOWNERS file which lists the AI team as an owner for mcp-integrations, whereas ai-integrations lists the UI team along with others from other teams (which is why I generalized to rhdh-team). The Qodo issue is stemming from the fact that rhdh-ai hasn't been added to catalog-info-teams.yaml, but this is copied from the Dev Hub instance that hasn't yet imported that group from Rover yet.

I think ultimately the owner annotation will just serve as an easy filter for teams for what they're responsible for, so we can always adjust in future to whatever is most useful. I'll update it to rhdh-team for now to avoid any breakages until the rhdh-ai group is added.

Copy link
Contributor

@gabemontero gabemontero Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah the catalog-info-team.yaml ref stirred some memory cells @hopehadfield .... we did something similar in the export overlays repo https://github.com/redhat-developer/rhdh-plugin-export-overlays/pull/1652/changes ... after we created that @redhat-developer/rhdh-ai github handle

I think there is a rhdh-ai rover handle .... I'll ask in slack and report back

Copy link
Member Author

@hopehadfield hopehadfield Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a group in Rover: https://rover.redhat.com/groups/group/rhdh-ai

I think it just needs to be synced with Dev Hub

Copy link
Contributor

@gabemontero gabemontero Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a group in Rover: https://rover.redhat.com/groups/group/rhdh-ai

I think it just needs to be synced with Dev Hub

by synced with Dev Hub you mean make a change to https://github.com/redhat-developer/rhdh-plugins/blob/main/catalog-info-teams.yaml ?

Or do you mean something else @hopehadfield

thanks

Copy link
Member Author

@hopehadfield hopehadfield Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm realizing that was a vague statement 😅 I mean the groups we have in the the internal Dev Hub instance. I think they're automatically imported by Rover, but I need to touch base with the DevIT team because the rhdh-ai group is missing.

Once that is updated, I'll update https://github.com/redhat-developer/rhdh-plugins/blob/main/catalog-info-teams.yaml

Copy link
Contributor

@gabemontero gabemontero Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha / no worries :-)

in the interim I'm going to update CODEOWNERS so rhdh-ai is also listed for ai-integrations

thanks

lifecycle: active
system: rhdh
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/openshift-image-registry/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@ metadata:
spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-team
system: rhdh
owner: rhdh-ui-team
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/quickstart/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ metadata:
# backstage.io/techdocs-ref: dir:.
spec:
type: backstage-plugin
owner: john@example.com
owner: rhdh-ui-team
lifecycle: active
system: rhdh
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/scorecard/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ metadata:
# backstage.io/techdocs-ref: dir:.
spec:
type: backstage-plugin
owner: john@example.com
owner: rhdh-team
lifecycle: active
system: rhdh
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/theme/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,5 @@ metadata:
spec:
type: backstage-plugin
lifecycle: active
owner: rhdh-team
system: rhdh
owner: rhdh-ui-team
subcomponentOf: rhdh-plugins
3 changes: 1 addition & 2 deletions workspaces/translations/catalog-info.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ metadata:
# backstage.io/techdocs-ref: dir:.
spec:
type: backstage-plugin
owner: john@example.com
owner: rhdh-ui-team
lifecycle: active
system: rhdh
subcomponentOf: rhdh-plugins