chore: remove system and update owners in catalog-info.yaml#2427
chore: remove system and update owners in catalog-info.yaml#2427hopehadfield wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
hopehadfield
requested review from
a team,
Eswaraiahsapram,
Lucifergene,
christoph-jerolimov,
ciiay,
debsmita1,
divyanshiGupta,
gabemontero,
its-mitesh-kumar,
johnmcollier,
karthikjeeyar,
logonoff,
rm3l,
rohitkrai03,
thepetk and
yangcao77
as code owners
Review Summary by QodoRemove system annotation and update ownership in catalog-info files
WalkthroughsDescription• Remove system: rhdh annotation from all catalog-info.yaml files • Update ownership assignments across multiple workspace plugins • Align catalog structure with IT Dev Hub RHDH organization • Change root repository type from backstage-plugin-repository to repository Diagramflowchart LR
A["catalog-info.yaml files"] -- "Remove system: rhdh" --> B["Simplified catalog structure"]
A -- "Update owner assignments" --> C["Team-based ownership"]
D["Root catalog-info.yaml"] -- "Change type to repository" --> B
C --> E["Aligned with RHDH structure"]
File Changes1. catalog-info.yaml
|
Code Review by Qodo
1. Undefined owner group
|
|
![rhdh-qodo-merge[bot]](https://avatars.githubusercontent.com/in/1961108?s=60&v=4){kind=small}
| spec: | ||
| type: backstage-plugin | ||
| owner: john@example.com | ||
| owner: rhdh-ai |
There was a problem hiding this comment.
1. Undefined owner group 🐞 Bug ✓ Correctness
workspaces/mcp-integrations/catalog-info.yaml now sets spec.owner: rhdh-ai, but no Group entity named rhdh-ai exists in the repo’s team definitions, so ownership relations/links (and any ownership-based workflows) will be broken for this component.
Agent Prompt
### Issue description
`workspaces/mcp-integrations/catalog-info.yaml` references an owner group (`rhdh-ai`) that is not defined in the repository’s group catalog descriptors, which breaks ownership relations.
### Issue Context
The repo includes `catalog-info-teams.yaml` with the defined team groups used in other catalog entries. `rhdh-ai` is not present there.
### Fix Focus Areas
- workspaces/mcp-integrations/catalog-info.yaml[10-14]
- catalog-info-teams.yaml[4-42]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
so @hopehadfield you used rhdh-team for the ai-integrations change .... unless @johnmcollier disagrees, I would suggest that whichever team is used for ai-integrations can be used for mcp-integrations
There was a problem hiding this comment.
Code Implementation 🛠️
Implementation: Update the component owner to an existing Group entity defined in the repository so ownership relations resolve correctly.
| owner: rhdh-ai | |
| owner: rhdh-team |
📄 References
See review comment here
There was a problem hiding this comment.
@gabemontero I was working based off the CODEOWNERS file which lists the AI team as an owner for mcp-integrations, whereas ai-integrations lists the UI team along with others from other teams (which is why I generalized to rhdh-team). The Qodo issue is stemming from the fact that rhdh-ai hasn't been added to catalog-info-teams.yaml, but this is copied from the Dev Hub instance that hasn't yet imported that group from Rover yet.
I think ultimately the owner annotation will just serve as an easy filter for teams for what they're responsible for, so we can always adjust in future to whatever is most useful. I'll update it to rhdh-team for now to avoid any breakages until the rhdh-ai group is added.
There was a problem hiding this comment.
ah the catalog-info-team.yaml ref stirred some memory cells @hopehadfield .... we did something similar in the export overlays repo https://github.com/redhat-developer/rhdh-plugin-export-overlays/pull/1652/changes ... after we created that @redhat-developer/rhdh-ai github handle
I think there is a rhdh-ai rover handle .... I'll ask in slack and report back
There was a problem hiding this comment.
There is a group in Rover: https://rover.redhat.com/groups/group/rhdh-ai
I think it just needs to be synced with Dev Hub
There was a problem hiding this comment.
There is a group in Rover: https://rover.redhat.com/groups/group/rhdh-ai
I think it just needs to be synced with Dev Hub
by synced with Dev Hub you mean make a change to https://github.com/redhat-developer/rhdh-plugins/blob/main/catalog-info-teams.yaml ?
Or do you mean something else @hopehadfield
thanks
There was a problem hiding this comment.
Sorry, I'm realizing that was a vague statement 😅 I mean the groups we have in the the internal Dev Hub instance. I think they're automatically imported by Rover, but I need to touch base with the DevIT team because the rhdh-ai group is missing.
Once that is updated, I'll update https://github.com/redhat-developer/rhdh-plugins/blob/main/catalog-info-teams.yaml
There was a problem hiding this comment.
gotcha / no worries :-)
in the interim I'm going to update CODEOWNERS so rhdh-ai is also listed for ai-integrations
thanks
gabemontero
left a comment
gabemontero
left a comment
There was a problem hiding this comment.
a suggestion based on the qodo call out
| spec: | ||
| type: backstage-plugin | ||
| owner: john@example.com | ||
| owner: rhdh-ai |
There was a problem hiding this comment.
so @hopehadfield you used rhdh-team for the ai-integrations change .... unless @johnmcollier disagrees, I would suggest that whichever team is used for ai-integrations can be used for mcp-integrations
2 participants
Hey, I just made a Pull Request!
This change is being made as a part of the dogfooding effort (specifically RHIDP-10958). It aims to restructure and clean up the relations graph by removing the
system: rhdhannotation, and by updating the ownership group. This is to align with the proposed IT Dev Hub RHDH Structure .Current Structure on Dev Hub:
New Structure:
cc @JessicaJHee
✔️ Checklist