Conversation
…ing in quoted GQL
…transport in mapping file
|
I had AI do a full review of the branches, it flagged the following: LULUCF removals get the wrong sign in the mapped form The two 1990 LULUCF queries disagree about what "LULUCF" means:
It's harmless today only because no dataset has an |
| # For example: | ||
| # - name: Use | ||
| # label: "Use" | ||
| # type: sector_mapping | ||
| # value: use | ||
| # - name: IPCC_CRT_code_agg | ||
| # label: "IPCC CRT code (aggregated)" | ||
| # type: sector_mapping | ||
| # value: ipcc_crt_code_agg |
There was a problem hiding this comment.
It's still valid, it gives an example of how we could add a new column to the data export and how this relates to the columns in the mapping file.
By IPCC definition, removals in LULUCF only apply for CO2. It's not possible to have removals for other GHG. I updated the descriptions in the doc strings to further clarify this. Note to ourselves: good practice to provide clear doc strings when queries deviate from "standard queries". This will also gives context to the AI review to understand why the query is different. |
Context
This PR adds the queries for a new chart and dashboard items, using a newly introduced mapping file structure.
Implemented changes
Related
Goes with pull requests:
Checklist