Skip to content

Direct emissions chart and dashboard items#4753

Merged
kndehaan merged 21 commits into
masterfrom
emissions-user-input-output
Jul 17, 2026
Merged

Direct emissions chart and dashboard items#4753
kndehaan merged 21 commits into
masterfrom
emissions-user-input-output

Conversation

@kndehaan

@kndehaan kndehaan commented Jul 16, 2026

Copy link
Copy Markdown
Member

Context

This is a new version of the accidentally closed PR #4730. This PR adds a chart and two dashboard items to the model as part of the direct emissions project.

Implemented changes

  • Direct total GHG emissions chart per sector
  • Dashboard items reduction in GHG emissions compared to 1990 and total future GHG emissions

Remarks:

  • Due to the new mapping setup, the direct emissions data export is not working anymore. This will be fixed in a separate PR.

Related

Goes with pull requests:

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

@mabijkerk

mabijkerk commented Jul 17, 2026

Copy link
Copy Markdown
Member

Are we adding data-exports for IPCC emissions as well at some point? Like: choose how to export your direct emissions, as ETM mapping, as IPCC mapping or Klimaattafel (or all?).

@mabijkerk

mabijkerk commented Jul 17, 2026

Copy link
Copy Markdown
Member

Chart is looking good! My earlier point of review still stands: you can get start and future year emissions in full detail in the data-exports, but 1990 data is not even visible in the chart. Would be good to address this at some point (not this PR).

@kndehaan

Copy link
Copy Markdown
Member Author

Are we adding data-exports for IPCC emissions as well at some point? Like: choose how to export your direct emissions, as ETM mapping, as IPCC mapping or Klimaattafel (or all?).

In the ideal state, users should be able to choose which mappings they want in their data export. But for now, the idea is to just expand the existing data export with the IPCC and Klimaattafel columns.

@kndehaan

kndehaan commented Jul 17, 2026

Copy link
Copy Markdown
Member Author

but 1990 data is not even visible in the chart. Would be good to address this at some point (not this PR).

I'll check with the devs if we could pick this up in the next increment. EDIT: first attempt done, see #4754 (comment)

@mabijkerk mabijkerk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kndehaan
kndehaan force-pushed the emissions-user-input-output branch from c358463 to 97ad0a3 Compare July 17, 2026 14:12
@kndehaan
kndehaan merged commit e52391d into master Jul 17, 2026
2 checks passed
@kndehaan
kndehaan deleted the emissions-user-input-output branch July 17, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants