Skip to content

Direct emissions chart and dashboard items#4730

Closed
kndehaan wants to merge 21 commits into
emissionsfrom
emissions-user-input-output
Closed

Direct emissions chart and dashboard items#4730
kndehaan wants to merge 21 commits into
emissionsfrom
emissions-user-input-output

Conversation

@kndehaan

@kndehaan kndehaan commented Jun 18, 2026

Copy link
Copy Markdown
Member

Context

This PR adds a chart and two dashboard items to the model as part of the direct emissions project.

Implemented changes

  • Direct total GHG emissions chart per sector
  • Dashboard items reduction in GHG emissions compared to 1990 and total future GHG emissions

Remarks:

  • Due to the new mapping setup, the direct emissions data export is not working anymore. This will be fixed in a separate PR.

Related

Goes with pull requests:

  • etengine, branch emissions-mapping
  • atlas, branch emissions-mapping
  • etsource, branch emissions-user-output-mapping
  • etmodel, branch emissions-user-input-output
  • documenation, branch emissions-user-input-output

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

@kndehaan
kndehaan changed the base branch from master to emissions June 18, 2026 11:50
@kndehaan
kndehaan force-pushed the emissions-user-input-output branch from 020ac67 to 6d93070 Compare June 18, 2026 11:51
@kndehaan kndehaan changed the title Direct emissions GHG chart and dashboard items Direct emissions 1990 data, chart and dashboard items Jun 18, 2026
Base automatically changed from emissions to master June 19, 2026 09:44
@kndehaan
kndehaan force-pushed the emissions-user-input-output branch from 2a34311 to 642e3da Compare June 19, 2026 10:04
@kndehaan
kndehaan requested a review from mabijkerk June 19, 2026 10:20
@kndehaan
kndehaan marked this pull request as ready for review June 29, 2026 10:17
@kndehaan
kndehaan force-pushed the emissions-user-input-output branch from b4467e1 to 5bc737d Compare July 7, 2026 13:20
@kndehaan
kndehaan changed the base branch from master to emissions July 7, 2026 13:21
@kndehaan kndehaan changed the title Direct emissions 1990 data, chart and dashboard items Direct emissions chart and dashboard items Jul 7, 2026
@mabijkerk

Copy link
Copy Markdown
Member

@kndehaan I think the new dashboard items should be selectable from the menu, not shown by default right? Now the bar is very cluttered:

image

@mabijkerk

Copy link
Copy Markdown
Member

Might it be better to put the direct GHG chart in the "Emissions" chart selection section while it is in beta, rather than in the "Overview" section?

image

@mabijkerk

mabijkerk commented Jul 9, 2026

Copy link
Copy Markdown
Member

Why are all the labels shown twice? Also, why is the red line shown twice in the 2050 emissions, why is it not shown for 1990?

image

@mabijkerk

mabijkerk commented Jul 9, 2026

Copy link
Copy Markdown
Member

Ideally you would also see a column for 1990 emissions in the table view of the chart.

image

@mabijkerk

Copy link
Copy Markdown
Member

I would add the new GHG chart as the default for the direct emissions download:
image

@kndehaan

kndehaan commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

I think the new dashboard items should be selectable from the menu, not shown by default right? Now the bar is very cluttered

This is a caching issue (right @louispt1 ?). If you click on the dasboard items settings wheel and save again, it shows the "normal" 7 dashboard items. But it I will ask @louispt1 and @noracato again about this caching issue to ensure that this will not occur on beta or master.

Might it be better to put the direct GHG chart in the "Emissions" chart selection section while it is in beta, rather than in the "Overview" section?

Sure, I'll move it there.

Why are all the labels shown twice? Also, why is the red line shown twice in the 2050 emissions, why is it not shown for 1990?

This is a bug that was already solved in one of the commits. Are you sure your local branch is up-to-date with remote? I don't see the duplicate labels:

image

Ideally you would also see a column for 1990 emissions in the table view of the chart.

I agree. I'll ask the devs to see if this would be very easy to implement.

I would add the new GHG chart as the default for the direct emissions download

Good point! I'll do that.

@mabijkerk

Copy link
Copy Markdown
Member

If you click on the dasboard items settings wheel and save again

I cannot see the wheel, so this does not work for me.

@mabijkerk

Copy link
Copy Markdown
Member

This is a bug that was already solved in one of the commits. Are you sure your local branch is up-to-date with remote? I don't see the duplicate labels:

Yes I'm sure, maybe I'm on the wrong branches?

  • etmodel: emissions-user-input-output
  • etsource: emissions-user-input-output
  • etengine: emissions-1990

@kndehaan

kndehaan commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

The wheel becomes visible when you zoom out the page a lot. You're using the correct branches. I think strange things are happening here that might be related to caching as well? I think we should discuss it with the devs.

@mabijkerk

Copy link
Copy Markdown
Member

Ideally you would also see a column for 1990 emissions in the table view of the chart.

@kndehaan what is the status here?

@mabijkerk

Copy link
Copy Markdown
Member

Aren't LULUCF and Internal transport a bit too similar in colour? The same might apply to Industry and Waste. Should we make LULUCF (light) green for example, Waste brown or (dark) green.

image

@mabijkerk

Copy link
Copy Markdown
Member

Do we have a 1990 data export? If so, I would add it here:

image

Comment thread config/locales/interface/en_dashboard_items.yml Outdated
Comment thread config/locales/interface/en_dashboard_items.yml
@louispt1 louispt1 mentioned this pull request Jul 14, 2026
3 tasks
@kndehaan

kndehaan commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

@kndehaan what is the status here?

It's estimated to take 2-4 hours. I now parked it as a should have (not must have). One thing that would require some consideration is how it would/should look like for the existing CO2 emissions chart. This one has three 1990 categories instead of the same categories as start and future year.

I think it's best to consider this in the follow up of this project. I'll open a new issue for this desired enhancement.

EDIT: added as issue #4754

The same might apply to Industry and Waste. Should we make LULUCF (light) green for example, Waste brown or (dark) green.

Implemented.

Do we have a 1990 data export?

We don't have a 1990 data export as of yet.

@kndehaan
kndehaan force-pushed the emissions-user-input-output branch from 0135fe2 to f942626 Compare July 15, 2026 09:33
@kndehaan
kndehaan deleted the branch emissions July 16, 2026 09:42
@kndehaan kndehaan closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants