Skip to content

Adapt threadpool for WASM/Emscripten compatibility #18106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Mar 12, 2026
+3 −2
Merged

Adapt threadpool for WASM/Emscripten compatibility #18106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extension/threadpool/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def define_common_targets():
"ovr_config//os:windows": [":threadpool_lib"],
"ovr_config//os:android": [":threadpool_lib"],
"ovr_config//os:iphoneos": [":threadpool_lib"],
"ovr_config//runtime:wasm-emscripten": [":threadpool_lib"],
# Machines without an operating system shouldn't.
"ovr_config//os:none": ["//executorch/runtime/kernel:thread_parallel_interface"],
# If we don't know what it is, disable threadpool out of caution.
Expand Down
4 changes: 2 additions & 2 deletions extension/threadpool/threadpool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

namespace executorch::extension::threadpool {

#if !(defined(WIN32))
#if !defined(WIN32) && !defined(__EMSCRIPTEN__)
namespace {
// After fork, the child process inherits the data-structures of the parent
// process' thread-pool, but since those threads don't exist, the thread-pool
Expand Down Expand Up @@ -153,7 +153,7 @@ ThreadPool* get_threadpool() {

// Inheriting from old threadpool to get around segfault issue
// commented above at child_atfork
#if !(defined(WIN32))
#if !defined(WIN32) && !defined(__EMSCRIPTEN__)
// @lint-ignore CLANGTIDY facebook-hte-std::once_flag
static std::once_flag flag;
// @lint-ignore CLANGTIDY facebook-hte-std::call_once
Expand Down
Loading