Skip to content

Adapt threadpool for WASM/Emscripten compatibility#18106

Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
s09g:export-D94744811
Mar 12, 2026
Merged

Adapt threadpool for WASM/Emscripten compatibility#18106
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
s09g:export-D94744811

Conversation

@s09g
Copy link
Contributor

@s09g s09g commented Mar 11, 2026

Summary:
Disable pthread_atfork-related code in threadpool when building for
Emscripten/WASM, since fork() is not supported in WASM environments.

Reviewed By: GregoryComer

Differential Revision: D94744811

@s09g s09g requested a review from kimishpatel as a code owner March 11, 2026 18:26
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 11, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18106

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ce1d716 with merge base 096f10c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 11, 2026

@s09g has exported this pull request. If you are a Meta employee, you can view the originating Diff in D94744811.

@s09g
Copy link
Contributor Author

s09g commented Mar 11, 2026

@pytorchbot label "release notes: build"

@pytorch-bot pytorch-bot bot added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Mar 11, 2026
Summary:

Disable pthread_atfork-related code in threadpool when building for
Emscripten/WASM, since fork() is not supported in WASM environments.

Reviewed By: GregoryComer

Differential Revision: D94744811
@s09g s09g force-pushed the export-D94744811 branch from 409bf1a to ce1d716 Compare March 11, 2026 19:05
@meta-codesync meta-codesync bot merged commit bb8a5df into pytorch:main Mar 12, 2026
159 of 160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants