Adapt threadpool for WASM/Emscripten compatibility#18106
Merged
meta-codesync[bot] merged 1 commit intopytorch:mainfrom Mar 12, 2026
Merged
Adapt threadpool for WASM/Emscripten compatibility#18106meta-codesync[bot] merged 1 commit intopytorch:mainfrom
meta-codesync[bot] merged 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18106
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ce1d716 with merge base 096f10c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Contributor
Author
|
@pytorchbot label "release notes: build" |
JacobSzwejbka
approved these changes
Mar 11, 2026
GregoryComer
approved these changes
Mar 11, 2026
Summary: Disable pthread_atfork-related code in threadpool when building for Emscripten/WASM, since fork() is not supported in WASM environments. Reviewed By: GregoryComer Differential Revision: D94744811
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Disable pthread_atfork-related code in threadpool when building for
Emscripten/WASM, since fork() is not supported in WASM environments.
Reviewed By: GregoryComer
Differential Revision: D94744811