Skip to content

gh-143504: Expose CELL status of a symbol in symtable #143549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yashp002 wants to merge 10 commits into
base: main
Choose a base branch
from
+17 −0
Open

gh-143504: Expose CELL status of a symbol in symtable #143549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b840e4e
symtable commit
Yashp002 Jan 8, 2026
0b676e4
symtable fix 1
Yashp002 Jan 8, 2026
2175829
symtable fix 2- news
Yashp002 Jan 8, 2026
17072bd
symtable fix 3
Yashp002 Jan 21, 2026
f096488
symtable fix 4
Yashp002 Jan 21, 2026
57b36be
symtable fix 5
Yashp002 Jan 21, 2026
5c558f4
symtable fix 5
Yashp002 Jan 21, 2026
19cd54d
Merge branch 'main' into symtable
Yashp002 Jan 21, 2026
a9e5bf7
symtable fix 6
Yashp002 Jan 22, 2026
f437b13
symtable fix 6
Yashp002 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Lib/symtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ class Function(SymbolTable):
__frees = None
__globals = None
__nonlocals = None
__cells = None

def __idents_matching(self, test_func):
return tuple(ident for ident in self.get_identifiers()
Expand Down Expand Up @@ -229,6 +230,13 @@ def get_frees(self):
self.__frees = self.__idents_matching(is_free)
return self.__frees

def get_cells(self):
"""Return a list of cell variable names in the table.
Copy link
Member

@picnixz picnixz Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Return a list of cell variable names in the table.
"""Return a tuple of cell variable names in the table.

"""
if self.__cells is None:
self.__cells = [s.get_name() for s in self.get_symbols() if s.is_cell()]
Copy link
Member

@iritkatriel iritkatriel Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the pattern that it used in get_frees:

Suggested change
self.__cells = [s.get_name() for s in self.get_symbols() if s.is_cell()]
is_cell = lambda x: _get_scope(x) == CELL
self.__cells = self.__idents_matching(is_cell)

return self.__cells


class Class(SymbolTable):

Expand Down Expand Up @@ -342,6 +350,10 @@ def is_free(self):
"""
return bool(self.__scope == FREE)

def is_cell(self):
"""Return *True* if the symbol is a cell variable."""
return bool(self.__scope == CELL)

def is_free_class(self):
"""Return *True* if a class-scoped symbol is free from
the perspective of a method."""
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_symtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,10 @@ def test_local(self):
def test_free(self):
self.assertTrue(self.internal.lookup("x").is_free())

def test_cells(self):
self.assertTrue(self.spam.lookup("x").is_cell())


Copy link
Member

@iritkatriel iritkatriel Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_cells is not tested at all.

Copy link
Member

@iritkatriel iritkatriel Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to test_function_info:

@@ -255,6 +255,7 @@ def test_function_info(self):
         self.assertEqual(sorted(func.get_locals()), expected)
         self.assertEqual(sorted(func.get_globals()), ["bar", "glob", "some_assigned_global_var"])
         self.assertEqual(self.internal.get_frees(), ("x",))
+        self.assertEqual(self.spam.get_cells(), ("some_var", "x",))

Copy link
Member

@picnixz picnixz Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

There ate 2 blanks instead of 1 here.

def test_referenced(self):
self.assertTrue(self.internal.lookup("x").is_referenced())
self.assertTrue(self.spam.lookup("internal").is_referenced())
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-01-08-16-28-03.gh-issue-143504.PlC_Yv.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add symtable.is_cell() and get_cells() methods for cell variable analysis.
Loading