gh-143504: Expose CELL status of a symbol in symtable #143549

Yashp002 · 2026-01-08T07:59:24Z

Expose cell status in symtable.Symbol via new is_cell() predicate and add get_cells() method to SymbolTable.

Changes

Added Symbol.is_cell() method that returns True if the symbol has the CELL flag.
Added SymbolTable.get_cells() method that returns an iterable of cell variable names.
Added test_cells to Lib/test/test_symtable.py to verify the new API.

Tests

Added test_cells test using a closure pattern (outer -> inner accessing x).

Issue: expose CELL status of a symbol in symtable #143504

Lib/symtable.py

Co-authored-by: AN Long <aisk@users.noreply.github.com>

Yashp002 · 2026-01-08T13:47:42Z

I'll fix this in a while, my apologies for quite a big fault in the code actually

iritkatriel · 2026-01-21T12:45:41Z

Lib/test/test_symtable.py

+        outer = find_block(top, "outer")
+        self.assertIn("x",outer.get_cells())
+        self.assertTrue(outer.lookup("x").is_cell())
+        self.assertFalse(outer.lookup("inner").is_cell())


Let's put this test next to test_free.

Lib/symtable.py

iritkatriel · 2026-01-21T12:51:42Z

Lib/symtable.py


+    def get_cells(self):
+        """Return a list of cell variable names in the table."""
+        return [s.get_name() for s in self.get_symbols() if s.is_cell()]


This probably belongs next to get_frees.

Yashp002 · 2026-01-21T18:00:46Z

@iritkatriel I was forced to force push the symtable branch due to me updating the branch before for the CI.

iritkatriel · 2026-01-21T18:37:01Z

Lib/symtable.py


+    def get_cells(self):
+        """Return a list of cell variable names in the table."""
+        return [s.get_name() for s in self.get_symbols() if s.is_cell()]


Why does this not follow the pattern of get_frees and get_nonlocals?

We'll have to use the _cells variable then, I'll add it.

iritkatriel · 2026-01-21T18:38:12Z

Lib/test/test_symtable.py

+        code="""def outer():
+                    x=1
+                    def inner():
+                        return x"""


the other tests don't do all this. Can we follow the same pattern in this one?

@iritkatriel I've implemented the change in symtable.py with get_cells

But the current test_cells seems to be the only one that keeps working after I've change it up quite a few times.

Is it really a requirement for it all to have the same pattern?

Unless there's a reason why we can't, then we should follow the same pattern. What's the difference between the cases?

self.internal has x as FREE var (for test_free). we need x as CELL var (outer scope). setUp doesn't have that so inline code is needed. However I've removed the unnecessary comments and changed the rest of it to

top=symtable.symtable(code,"?","exec") outer = find_block(top, "outer") self.assertEqual(outer.get_cells(), ["x"]) self.assertTrue(outer.lookup("x").is_cell()) self.assertFalse(outer.lookup("inner").is_cell()) to use assert.Equal,true and false like the rest of the functions. WOuld this be satisfactory as a commit?

self.spam.lookup("x").is_cell()

and get_cells test should be next to get_frees test.

and get_cells test should be next to get_frees test.

isn't test_cells already next to test_free?

iritkatriel · 2026-01-23T20:56:09Z

Lib/test/test_symtable.py

-        self.assertFalse(outer.lookup("inner").is_cell())
+        self.assertTrue(self.spam.lookup("x").is_cell())
+



get_cells is not tested at all.

Add it to test_function_info:

@@ -255,6 +255,7 @@ def test_function_info(self): self.assertEqual(sorted(func.get_locals()), expected) self.assertEqual(sorted(func.get_globals()), ["bar", "glob", "some_assigned_global_var"]) self.assertEqual(self.internal.get_frees(), ("x",)) + self.assertEqual(self.spam.get_cells(), ("some_var", "x",))

iritkatriel · 2026-01-23T21:02:32Z

Lib/symtable.py

+        """Return a list of cell variable names in the table.
+        """
+        if self.__cells is None:
+            self.__cells = [s.get_name() for s in self.get_symbols() if s.is_cell()]


Let's follow the pattern that it used in get_frees:

Suggested change

self.__cells = [s.get_name() for s in self.get_symbols() if s.is_cell()]

is_cell = lambda x: _get_scope(x) == CELL

self.__cells = self.__idents_matching(is_cell)

picnixz · 2026-01-23T22:35:54Z

Can you also update symtable.rst? and add a What's New entry? (I did so for what I changed in 3.14)

And once you update the docs, update the NEWS entry to point them to

picnixz · 2026-01-23T22:36:45Z

Lib/symtable.py

        return self.__frees

+    def get_cells(self):
+        """Return a list of cell variable names in the table.


Suggested change

"""Return a list of cell variable names in the table.

"""Return a tuple of cell variable names in the table.

picnixz · 2026-01-23T22:37:28Z

Lib/test/test_symtable.py

+    def test_cells(self):
+        self.assertTrue(self.spam.lookup("x").is_cell())
+
+


Suggested change

There ate 2 blanks instead of 1 here.

symtable commit

b840e4e

bedevere-app bot added the awaiting review label Jan 8, 2026

Yashp002 changed the title ~~bpo-143504: Expose CELL status of a symbol in symtable (GH-143504)~~ gh-143504: Expose CELL status of a symbol in symtable (GH-143504) Jan 8, 2026

bedevere-app bot mentioned this pull request Jan 8, 2026

expose CELL status of a symbol in symtable #143504

Open

aisk reviewed Jan 8, 2026

View reviewed changes

Lib/symtable.py Show resolved Hide resolved

Yashp002 and others added 2 commits January 8, 2026 16:17

symtable fix 1

0b676e4

Co-authored-by: AN Long <aisk@users.noreply.github.com>

symtable fix 2- news

2175829

Yashp002 added 2 commits January 21, 2026 15:51

symtable fix 3

17072bd

symtable fix 4

f096488

iritkatriel reviewed Jan 21, 2026

View reviewed changes

Lib/symtable.py Show resolved Hide resolved

iritkatriel reviewed Jan 21, 2026

View reviewed changes

Yashp002 added 2 commits January 21, 2026 23:27

symtable fix 5

57b36be

symtable fix 5

5c558f4

Yashp002 force-pushed the symtable branch from bb93117 to 5c558f4 Compare January 21, 2026 18:00

Merge branch 'main' into symtable

19cd54d

iritkatriel reviewed Jan 21, 2026

View reviewed changes

Yashp002 added 2 commits January 22, 2026 15:53

symtable fix 6

a9e5bf7

symtable fix 6

f437b13

iritkatriel reviewed Jan 23, 2026

View reviewed changes

picnixz reviewed Jan 23, 2026

View reviewed changes

picnixz changed the title ~~gh-143504: Expose CELL status of a symbol in symtable (GH-143504)~~ gh-143504: Expose CELL status of a symbol in symtable Jan 23, 2026

		self.assertFalse(outer.lookup("inner").is_cell())
		self.assertTrue(self.spam.lookup("x").is_cell())

	self.__cells = [s.get_name() for s in self.get_symbols() if s.is_cell()]
	is_cell = lambda x: _get_scope(x) == CELL
	self.__cells = self.__idents_matching(is_cell)

	"""Return a list of cell variable names in the table.
	"""Return a tuple of cell variable names in the table.

		def test_cells(self):
		self.assertTrue(self.spam.lookup("x").is_cell())

Uh oh!

gh-143504: Expose CELL status of a symbol in symtable #143549

Are you sure you want to change the base?

gh-143504: Expose CELL status of a symbol in symtable #143549

Conversation

Yashp002 commented Jan 8, 2026 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Tests

Uh oh!

Uh oh!

Yashp002 commented Jan 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yashp002 commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

picnixz commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Yashp002 commented Jan 8, 2026 •

edited by bedevere-app bot

Loading

picnixz commented Jan 23, 2026 •

edited

Loading