Re-sync from template: consolidate CODESTYLE, tasks, smoke skip#182
Merged
Conversation
Applies the three template changes from issue #176's 2026-06-22 comment (upstream cde3354/f526b55/402e862): - copilot-instructions.md: re-sync the hardened Copilot review runbook verbatim (clean-pass-is-success, round-1 auto-seed polling, REST vs GraphQL bot-login, issue-comment bot-id fallback); re-adapt owner/repo placeholders and drop the inapplicable Python pointer. - CODESTYLE.md: consolidate into one guide - General + .NET sections, Python section dropped (droppable per-language model); adapt the project list, InternalsVisibleTo name, task labels, and Husky.Net note. - .vscode/tasks.json, launch.json, .husky/task-runner.json: .Net -> .NET casing; add dependsOrder: sequence to the .NET Format task. - build-nugetlibrary-task.yml: add smoke input, gate the zip/upload on !inputs.smoke; build-release-task.yml forwards smoke to the call. - .editorconfig: Json/JsonC comment and the suppression-policy note. - AGENTS.md: update CODESTYLE re-sync guidance to the droppable-section model and add the tasks.json verbatim-carry note. Build: 0 warnings / 0 errors. Tests: 257/257 pass.
Contributor
There was a problem hiding this comment.
Pull request overview
Re-syncs LanguageTags repo scaffolding and contributor guidance from the upstream template, focusing on consolidating code-style documentation, aligning VS Code/Husky task naming, and reducing CI artifact storage for PR smoke builds.
Changes:
- Consolidate
CODESTYLE.mdinto a repo-wide General section plus a droppable .NET section, and update re-sync guidance inAGENTS.md. - Normalize
.NETcasing across VS Code tasks/launch config and Husky task runner, and enforce sequential task dependencies for.NET Format. - Add a
smokeinput to the NuGet build reusable workflow to skip zip/upload steps during PR smoke runs, and forward that input from the release workflow.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CODESTYLE.md | Consolidates style guidance into General + .NET sections; updates clean-compile and suppression guidance. |
| AGENTS.md | Updates template re-sync instructions to the droppable-section model and adds tasks.json verbatim-carry guidance. |
| .vscode/tasks.json | Renames .Net* tasks to .NET*, adds group comments, and forces sequential .NET Format dependency execution. |
| .vscode/launch.json | Updates preLaunchTask to the new .NET Build label. |
| .husky/task-runner.json | Updates Husky task naming to .NET Format casing. |
| .github/workflows/build-release-task.yml | Forwards smoke into the NuGet build task to suppress artifact creation on smoke runs. |
| .github/workflows/build-nugetlibrary-task.yml | Introduces smoke input and skips zip/upload steps when enabled. |
| .github/copilot-instructions.md | Re-syncs and clarifies Copilot runbook framing and CODESTYLE reference. |
| .editorconfig | Updates JSON/JSONC comment and adds suppression-policy guidance comments for the C# block. |
The carried template line claimed CI runs `dotnet csharpier check`; this repo's test-pull-request.yml runs `dotnet husky run` (CSharpier + `dotnet format style --verify-no-changes`). Describe the actual CI.
This was referenced Jun 22, 2026
ptr727
added a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-converges with
ptr727/ProjectTemplatedevelop, applying the three template changes tracked in #176's 2026-06-22 comment (upstreamcde3354/f526b55/402e862). The earlier #176 body was already applied in 56863c4; this PR covers what landed upstream afterward.Changes
#173): re-synced.github/copilot-instructions.mdverbatim - clean-pass-is-success, round-1 auto-seed polling, REST-vs-GraphQL bot-login, issue-comment bot-id fallback. Re-adapted the<owner>/<repo>snippet placeholders to this repo, kept<N>as the per-PR placeholder, and dropped the inapplicable Python style pointer.CODESTYLE.md(#175/#178): one guide with a General section plus the .NET section; Python section dropped under the droppable-per-language model. Adapted the project-folder list,InternalsVisibleToname, build-task labels, and the Husky.Net hooks note to this repo.#175):.Net*→.NET*intasks.json,launch.json, and.husky/task-runner.json; added"dependsOrder": "sequence"to the.NET Formattask and the template's group comments. KeptHusky.Net Run, dropped.NET Benchmark(no such project).#179): added asmokeinput tobuild-nugetlibrary-task.ymlgating the zip + upload on!inputs.smoke;build-release-task.ymlforwardssmoke. Surgical edits - the local two-phase CI structure and SHA pins (ahead of the template) are preserved..editorconfig: adopted theJson and JsonCcomment and the suppression-policy note (now byte-identical to the template).AGENTS.md: updated the CODESTYLE re-sync guidance to the droppable-section model and added thetasks.jsonverbatim-carry note.Notes
CODESTYLE.md, since it presupposes a Python side this repo doesn't have..md/config files kept CRLF per.editorconfig; LF preserved on the workflow files; no.cs/.csprojtouched.Verification
dotnet build: 0 warnings / 0 errorsdotnet test: 257/257 pass