Skip to content

Promote develop to main: template re-sync (CODESTYLE, tasks, CI smoke)#183

Merged
ptr727 merged 2 commits into
mainfrom
develop
Jun 22, 2026
Merged

Promote develop to main: template re-sync (CODESTYLE, tasks, CI smoke)#183
ptr727 merged 2 commits into
mainfrom
develop

Conversation

@ptr727

@ptr727 ptr727 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Maintenance promotion of develop to main (merge-commit per the main ruleset). No functional change and no version.json bump - main advances only its NBGV height.

Carries the single develop commit since the last promotion:

  • c5bdb2f Re-sync from template: consolidate CODESTYLE, tasks, smoke skip (Re-sync from template: consolidate CODESTYLE, tasks, smoke skip #182)
    • Hardened Copilot review runbook in .github/copilot-instructions.md (verbatim from template, placeholders re-adapted)
    • Consolidated CODESTYLE.md into General + .NET sections (Python section dropped, droppable per-language model); CI lint backstop corrected to dotnet husky run
    • .NET task casing + dependsOrder: sequence across tasks.json / launch.json / .husky/task-runner.json
    • PR smoke builds skip the artifact zip/upload (build-nugetlibrary-task.yml + build-release-task.yml)
    • .editorconfig Json/JsonC + suppression-policy comments (now template-identical)
    • AGENTS.md re-sync guidance updated to the droppable-section model + tasks.json carry note

Reviewed on #182 (two Copilot rounds: one doc fix applied, one finding declined with rationale).

Re-converges with ptr727/ProjectTemplate develop (issue #176 follow-ups, upstream cde3354/f526b55/402e862): hardened Copilot runbook, consolidated CODESTYLE.md (General + .NET, Python dropped), .NET task casing + dependsOrder, PR smoke artifact skip, .editorconfig comments, AGENTS.md re-sync guidance. CI lint backstop doc corrected to husky-run.
Copilot AI review requested due to automatic review settings June 22, 2026 17:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes develop to main for a template re-sync, updating repo-wide guidance/docs, VS Code + Husky task naming, and PR smoke build behavior (skip artifact packaging/upload) without changing library functionality.

Changes:

  • Consolidates/updates CODESTYLE.md and related guidance in AGENTS.md / .github/copilot-instructions.md to match the template’s “General + droppable language sections” model.
  • Normalizes .NET task casing across VS Code (tasks.json, launch.json) and Husky (.husky/task-runner.json), and enforces sequential task dependency ordering.
  • Adds a smoke input to build-nugetlibrary-task.yml and forwards it from build-release-task.yml to skip artifact zip/upload during PR smoke builds.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CODESTYLE.md Reworked into “General” + “.NET” sections; updates clean-compile, linting, and suppression guidance.
AGENTS.md Updates template re-sync guidance, including explicit carry rules for clean-compile tasks.
.vscode/tasks.json Renames .Net* tasks to .NET*, adds sequential dependency ordering, and clarifying comments.
.vscode/launch.json Updates preLaunchTask to match the .NET Build task label.
.husky/task-runner.json Renames Husky task .Net Format to .NET Format for consistent casing.
.github/workflows/build-release-task.yml Forwards smoke into the NuGet build reusable workflow to support smoke-mode behavior.
.github/workflows/build-nugetlibrary-task.yml Introduces smoke input and gates zip/upload steps on !smoke to reduce PR artifact usage.
.github/copilot-instructions.md Re-sync/hardening + updated pointers to consolidated code-style guidance.
.editorconfig Updates Json/JsonC comment and adds suppression-policy guidance comment for .NET section.

Comment thread CODESTYLE.md
…ving (#184)

Conform LanguageTagTests.cs to the new CODESTYLE no-#pragma rule: CA1508 via [SuppressMessage], CS8602 via the null-forgiving operator (compiler diagnostics can't use [SuppressMessage]). No #pragma remain.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comment thread LanguageTagsTests/LanguageTagTests.cs
@ptr727 ptr727 merged commit b88d3c4 into main Jun 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants