Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions plugins/promptfoo/src/generator/config-filename.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import * as fs from 'node:fs';
import * as os from 'node:os';
import * as path from 'node:path';

import { afterEach, describe, expect, it } from 'vitest';

import { generateConfig } from './config.js';

const tempDirs: string[] = [];

afterEach(() => {
for (const dir of tempDirs.splice(0)) {
fs.rmSync(dir, { recursive: true, force: true });
}
});

describe('generateConfig filename handling', () => {
it('keeps the requested filename while writing a stable verify config alias', () => {
const outputDir = fs.mkdtempSync(path.join(os.tmpdir(), 'crabcode-config-'));
tempDirs.push(outputDir);

const generated = generateConfig({
description: 'Custom filename config',
providerType: 'http',
providerConfig: { url: 'https://example.com', method: 'GET' },
outputDir,
filename: 'custom-config.yaml',
});

expect(generated.filePath).toBe(path.join(outputDir, 'custom-config.yaml'));
expect(generated.verifyPath).toBe('promptfooconfig.yaml');
expect(fs.readFileSync(generated.filePath, 'utf-8')).toBe(
fs.readFileSync(path.join(outputDir, generated.verifyPath), 'utf-8')
);
});
});
2 changes: 1 addition & 1 deletion plugins/promptfoo/src/generator/config-outputdir.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('generateConfig output paths', () => {
});

expect(generated.filePath).toBe(path.join(outputDir, 'nested-config.yaml'));
expect(generated.verifyPath).toBe('nested-config.yaml');
expect(generated.verifyPath).toBe('promptfooconfig.yaml');
expect(fs.existsSync(generated.filePath)).toBe(true);
});
});
11 changes: 9 additions & 2 deletions plugins/promptfoo/src/generator/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ export interface GeneratedConfig {
envVars: Record<string, string>;
}

const DEFAULT_CONFIG_FILENAME = 'promptfooconfig.yaml';

/**
* Generate a promptfoo YAML config
*/
Expand All @@ -35,7 +37,7 @@ export function generateConfig(options: GenerateConfigOptions): GeneratedConfig
providerConfig,
envVars = {},
outputDir = '.',
filename = 'promptfooconfig.yaml',
filename = DEFAULT_CONFIG_FILENAME,
} = options;

// Validate providerConfig has required fields for http provider
Expand Down Expand Up @@ -101,11 +103,16 @@ ${Object.entries(envVars).map(([k, v]) => `# ${k}: ${v}`).join('\n') || '# (
// Write the file
const filePath = path.join(outputDir, filename);
fs.writeFileSync(filePath, fullYaml, 'utf-8');
const verifyPath = DEFAULT_CONFIG_FILENAME;

if (verifyPath !== filename) {
fs.writeFileSync(path.join(outputDir, verifyPath), fullYaml, 'utf-8');
}

return {
yaml: fullYaml,
filePath,
verifyPath: filename,
verifyPath,
envVars,
};
}
Expand Down