Skip to content

[codex] Fix code scanning alert 3 in generated config filename flow#100

Closed
jbeckwith-oai wants to merge 1 commit intocodex/fix-codeql-alert-2-config-outputdirfrom
codex/fix-codeql-alert-3-config-filename
Closed

[codex] Fix code scanning alert 3 in generated config filename flow#100
jbeckwith-oai wants to merge 1 commit intocodex/fix-codeql-alert-2-config-outputdirfrom
codex/fix-codeql-alert-3-config-filename

Conversation

@jbeckwith-oai
Copy link
Copy Markdown
Contributor

Summary

  • keep the requested config filename for the user-facing output
  • write a stable promptfooconfig.yaml alias for verification
  • add a regression test for custom filenames plus the stable verify alias

Root cause

After the output-directory flow was separated, CodeQL still tracked the caller-controlled filename into the verify path that eventually reached promptfoo eval.

Validation

  • npm test -- src/generator/config-filename.test.ts src/generator/config-outputdir.test.ts
  • npm run build

@jbeckwith-oai
Copy link
Copy Markdown
Contributor Author

Superseded by #101 after collapsing the stacked promptfoo verification alerts into a single PR.

@jbeckwith-oai
Copy link
Copy Markdown
Contributor Author

Closing this draft in favor of #101, which now carries alerts 1-3 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant