Skip to content

fix(bling): skip brew bundle when bluefin-cli disables bling#362

Open
hanthor wants to merge 4 commits into
mainfrom
fix/bluefin-cli-bling-removal-164
Open

fix(bling): skip brew bundle when bluefin-cli disables bling#362
hanthor wants to merge 4 commits into
mainfrom
fix/bluefin-cli-bling-removal-164

Conversation

@hanthor
Copy link
Copy Markdown
Member

@hanthor hanthor commented May 30, 2026

Closes #164

hanthor added 3 commits May 30, 2026 02:43
chore: update codeowners and add pull request template
ublue-bling now exits 1 on disable, 0 on enable.
bluefin-cli recipe only runs brew bundle when bling is enabled.
Also fixes fallback sed path (hardcoded .bashrc -> TARGET_CONFIG_FILE).

Closes #164
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

Warning

Review limit reached

@hanthor, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 28 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c1b31e4-f76a-4bbd-94f0-0a7aea35e63b

📥 Commits

Reviewing files that changed from the base of the PR and between 7afdb10 and 384fd37.

📒 Files selected for processing (3)
  • system_files/bluefin/etc/profile.d/caffeinate.sh
  • system_files/bluefin/usr/share/ublue-os/just/system.just
  • system_files/shared/usr/bin/ublue-bling
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bluefin-cli-bling-removal-164

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added area/bling Anything to do with motd, terminal bling, charm and gum things area/just Justfile things kind/bug Something isn't working labels May 30, 2026
Copy link
Copy Markdown
Member Author

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Small-scope, concrete fix. No issues found.

@castrojo
Copy link
Copy Markdown
Contributor

🤖 Copilot Test Report

Branch: fix/bluefin-cli-bling-removal-164 | 7 commits behind main | Tested: 2026-05-30T04:51Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ✅ Near head

Change

Simplifies bluefin-cli recipe to ublue-bling && brew bundle — brew only runs if bling enable exits 0.

⚠️ Overlap with #358

Both PRs modify the same recipe. #358 is a more complete fix — it explicitly checks whether bling was enabled/disabled and skips brew on disable. This PR's && approach works when bling fails but still runs brew when disabling bling successfully. Reviewers should prefer #358 for the more correct semantics.

@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/bling Anything to do with motd, terminal bling, charm and gum things area/just Justfile things kind/bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ujust bluefin-cli does not remove bling

2 participants