Skip to content

fix(ujust): only run brew bundle when enabling bluefin-cli#358

Open
hanthor wants to merge 1 commit into
mainfrom
fix/bluefin-cli-toggle-brew
Open

fix(ujust): only run brew bundle when enabling bluefin-cli#358
hanthor wants to merge 1 commit into
mainfrom
fix/bluefin-cli-toggle-brew

Conversation

@hanthor
Copy link
Copy Markdown
Member

@hanthor hanthor commented May 29, 2026

Summary

Fixes #164: ujust bluefin-cli no longer reinstalls Homebrew CLI packages when disabling bling.

Problem

The bluefin-cli recipe always ran brew bundle --file=/usr/share/ublue-os/homebrew/cli.Brewfile after toggling bling. When a user disabled bling, the recipe would:

  1. Remove the bling source line from shell config ✅
  2. Then reinstall all Homebrew packages anyway ❌

Fix

Before toggling bling, the recipe now checks whether bling is currently installed (by looking for the bling source line in the shell config). It only runs brew bundle when bling was not installed — meaning the user is enabling bling.

Closes #164

Test plan

  • Running ujust bluefin-cli when bling is enabled should disable bling without reinstalling brew packages
  • Running ujust bluefin-cli when bling is disabled should enable bling and install brew packages

Previously the bluefin-cli recipe always ran 'brew bundle' after
toggling bling, which meant disabling bling would reinstall all
Homebrew CLI packages unnecessarily.

Now the recipe checks whether bling is already installed before
toggling, and only runs brew bundle when enabling (i.e., bling
was not previously installed).

Closes #164
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@hanthor, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 24 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a4146858-e3b9-4356-93c9-412a58f15313

📥 Commits

Reviewing files that changed from the base of the PR and between a9330df and d3092f5.

📒 Files selected for processing (1)
  • system_files/bluefin/usr/share/ublue-os/just/system.just
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bluefin-cli-toggle-brew

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added area/brew Homebrew things area/just Justfile things kind/bug Something isn't working labels May 29, 2026
Copy link
Copy Markdown
Member Author

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: Only runs brew bundle when explicitly enabling bluefin-cli. Correct fix — prevents unnecessary brew operations on every ujust invocation.

@castrojo
Copy link
Copy Markdown
Contributor

🤖 Copilot Test Report

Branch: fix/bluefin-cli-toggle-brew | 6 commits behind main | Tested: 2026-05-30T04:51Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ✅ Near head

Change

Expands bluefin-cli recipe in system.just to detect whether bling was already installed before toggling, and only runs brew bundle when enabling (not when disabling).

⚠️ Overlap with #362

Both PRs fix the same bluefin-cli recipe:

PR Approach
#358 (this) Full shell expansion — detects shell type, checks if bling was installed, skips brew on disable
#362 One-liner: ublue-bling && brew bundle — simple short-circuit, brew only runs if bling enable succeeds

These cannot both merge. #358 is the more correct fix (brew should be skipped when disabling). #362 is a partial fix (brew skips on bling failure, but still runs on disable if bling 'succeeds' at disabling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/brew Homebrew things area/just Justfile things kind/bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ujust bluefin-cli does not remove bling

2 participants