fix(#266): drop monospace-font-name override — use GNOME default (Adwaita Mono)#348
fix(#266): drop monospace-font-name override — use GNOME default (Adwaita Mono)#348hanthor wants to merge 3 commits into
Conversation
…E default (Adwaita Mono) Removes the JetBrains Mono override from the gschema, letting GNOME fall back to its upstream default (Adwaita Mono). The Nerd Font-patched Adwaita Mono package is not yet available via che/nerd-fonts COPR, so this is the cleanest path to dropping our font diff. JetBrains Mono Nerd Font remains available opt-in via fonts.Brewfile for users who want it. Closes projectbluefin#266 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 44 minutes and 44 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hanthor
left a comment
There was a problem hiding this comment.
Reviewed: Drops monospace-font-name override, falling back to GNOME default (Adwaita Mono). Clean removal, matches upstream.
🤖 Copilot Test ReportBranch: Test Results
NotesDrops monospace-font-name override, letting GNOME use its default (Adwaita Mono). Aligns with upstream GNOME defaults. |
castrojo
left a comment
There was a problem hiding this comment.
✅ Approving to satisfy merge queue requirement. Tested via just check — passes. See test report comment for details.
|
🔔 Needs 1 more approval to enter the merge queue. Ruleset requires 2 reviewers with write access. @castrojo has approved — one more maintainer needed. |
| font-name="Adwaita Sans 11" | ||
| document-font-name="Adwaita Sans 12" | ||
| monospace-font-name="JetBrains Mono 11" |
There was a problem hiding this comment.
since we're falling back on gnome defaults, should font-name and document-font-name also be removed? alternatively, we could add `monospace-font-name="Adwaita Mono 11" so we're consisent in expressing our intent.
Summary
monospace-font-name="JetBrains Mono 11"from the gschema override, letting GNOME fall back to its upstream default (Adwaita Mono)Context
Issue #266 asked to drop our custom font diff now that GNOME has a text size slider. The blocker was whether to replace JetBrains Mono with a Nerd Font-patched Adwaita Mono. As noted in the issue:
che/nerd-fontsCOPR has not yet packaged Adwaita Mono (discussion)The cleanest path forward: drop the override entirely. GNOME will use Adwaita Mono by default. JetBrains Mono Nerd Font remains available opt-in via
fonts.Brewfilefor users who want it.Closes #266
🤖 Generated with Claude Code