Skip to content

fix(#266): drop monospace-font-name override — use GNOME default (Adwaita Mono)#348

Open
hanthor wants to merge 3 commits into
projectbluefin:mainfrom
hanthor:fix/266-drop-monospace-font-diff
Open

fix(#266): drop monospace-font-name override — use GNOME default (Adwaita Mono)#348
hanthor wants to merge 3 commits into
projectbluefin:mainfrom
hanthor:fix/266-drop-monospace-font-diff

Conversation

@hanthor
Copy link
Copy Markdown
Member

@hanthor hanthor commented May 24, 2026

Summary

  • Removes monospace-font-name="JetBrains Mono 11" from the gschema override, letting GNOME fall back to its upstream default (Adwaita Mono)

Context

Issue #266 asked to drop our custom font diff now that GNOME has a text size slider. The blocker was whether to replace JetBrains Mono with a Nerd Font-patched Adwaita Mono. As noted in the issue:

The cleanest path forward: drop the override entirely. GNOME will use Adwaita Mono by default. JetBrains Mono Nerd Font remains available opt-in via fonts.Brewfile for users who want it.

Closes #266

🤖 Generated with Claude Code

…E default (Adwaita Mono)

Removes the JetBrains Mono override from the gschema, letting GNOME fall
back to its upstream default (Adwaita Mono). The Nerd Font-patched Adwaita
Mono package is not yet available via che/nerd-fonts COPR, so this is the
cleanest path to dropping our font diff. JetBrains Mono Nerd Font remains
available opt-in via fonts.Brewfile for users who want it.

Closes projectbluefin#266

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@hanthor, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 44 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 31e8395b-43f9-429b-9b38-69ae17065ac6

📥 Commits

Reviewing files that changed from the base of the PR and between d28b37e and cd36f3e.

📒 Files selected for processing (1)
  • system_files/bluefin/usr/share/glib-2.0/schemas/zz0-bluefin-modifications.gschema.override
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot Bot added the area/gnome Anything GNOME related label May 24, 2026
Copy link
Copy Markdown
Member Author

@hanthor hanthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: Drops monospace-font-name override, falling back to GNOME default (Adwaita Mono). Clean removal, matches upstream.

@castrojo castrojo enabled auto-merge May 30, 2026 04:30
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 30, 2026
@castrojo
Copy link
Copy Markdown
Contributor

🤖 Copilot Test Report

Branch: fix/266-drop-monospace-font-diff | 17 commits behind main | Tested: 2026-05-30T04:51Z

Test Results

Test Result
just check (syntax validation) ✅ PASS
Branch freshness ✅ Near head

Notes

Drops monospace-font-name override, letting GNOME use its default (Adwaita Mono). Aligns with upstream GNOME defaults.

Copy link
Copy Markdown
Contributor

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving to satisfy merge queue requirement. Tested via just check — passes. See test report comment for details.

@castrojo
Copy link
Copy Markdown
Contributor

🔔 Needs 1 more approval to enter the merge queue. Ruleset requires 2 reviewers with write access. @castrojo has approved — one more maintainer needed.

@castrojo castrojo requested a review from ahmedadan as a code owner May 30, 2026 05:47
@castrojo castrojo closed this May 30, 2026
auto-merge was automatically disabled May 30, 2026 07:39

Pull request was closed

@castrojo castrojo reopened this May 30, 2026
@castrojo castrojo closed this May 30, 2026
@castrojo castrojo reopened this May 30, 2026
@hanthor hanthor enabled auto-merge May 30, 2026 12:30
Comment on lines 18 to -20
font-name="Adwaita Sans 11"
document-font-name="Adwaita Sans 12"
monospace-font-name="JetBrains Mono 11"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're falling back on gnome defaults, should font-name and document-font-name also be removed? alternatively, we could add `monospace-font-name="Adwaita Mono 11" so we're consisent in expressing our intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/gnome Anything GNOME related lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop our font diff entirely

3 participants