Switch default monospace font from JetBrains Mono to AdwaitaMono Nerd Font#271
Switch default monospace font from JetBrains Mono to AdwaitaMono Nerd Font#271Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/projectbluefin/common/sessions/9b14caa3-0573-41b9-9c8e-6248b90abd05 Co-authored-by: hanthor <5840441+hanthor@users.noreply.github.com>
|
bluefin currently includes adwaita-fonts-all and jetbrains-mono-fonts-all. these normal fonts are then patched by nerd-fonts from che/nerd-fonts. unfortunately, che/nerdfonts have not yet updated their package for ideally, you'd want to follow the same approach (install normal font, patch with nerd-fonts). however, the fact that once this is merged in |
| RUN install -d /out/shared/usr/share/fonts/AdwaitaMono && \ | ||
| curl -fsSLo /tmp/AdwaitaMono.tar.xz https://github.com/ryanoasis/nerd-fonts/releases/download/v3.4.0/AdwaitaMono.tar.xz && \ | ||
| tar -xJf /tmp/AdwaitaMono.tar.xz -C /out/shared/usr/share/fonts/AdwaitaMono && \ | ||
| rm /tmp/AdwaitaMono.tar.xz |
There was a problem hiding this comment.
There's got to be an official way to get this font from GNOME itself?
There was a problem hiding this comment.
gnome already provides adwaita fonts by default. the mono font even comes with nerd font icons built-in. except, the git branch icon doesn't render correctly.
we could just remove adwaita and jetbrains fonts from packages.sh to align with upstream. plus, maybe the git branch icon getting chopped should be a bug report to gnome?
see the stock silverblue 43 image below for reference:
|
SGTM, is there a fallback? I know in the past this would break people's terminals font until they fixed it. |
|
wdym by fallback font? the bundled adwaita mono works fine except the git symbol as far as i know. rn we're explicitly installing in order to not degrade the ux, here's what i suggest:
once upstream fixes their font, we can back out jetbrains and set adwaita mono as the default font for new installations. also not that upstream ships a number of monospace fonts like noto sans mono, liberation mono, dejavu sans mono, etc. we could also pick one of them as the default instead of shipping jetbrains font, if desired. |
|
Opened issue upstream: https://gitlab.gnome.org/GNOME/adwaita-fonts/-/work_items/27. |
|
upstream has closed the ticket - they won't provide a fix. so, @castrojo, your call as to how you'd like this tackled. we could just keep i've used both the upstream upstream
nf
the two symbols noted render slightly differently but i'm not quite sure if anything is broken. i think we can 100% go with the upstream font, no issue. let me know what you think. |
|
Thanks for all the work! Let's fix the font size to be normal. This is an artifact of when it was a personal image of mine and I roll with large fonts. The new font slider thing in GNOME is awesome so we can just ship stock. Let's keep Jetbrains Mono for now it's got the full nerd coverage and it's still an awesome font. |
|
ok, i'm going to create a pull request with the following config shortly: |
Adjust size of system fonts to match default upstream settings [1]. We're sticking with JetBrains Mono as the default monospace font since the upstream Adwaita Mono font renders nerd font symbols differently to all other nerd fonts [2]. This addresses projectbluefin#266 and supersedes projectbluefin#271. [1] projectbluefin#271 (comment) [2] projectbluefin#271 (comment)
hanthor
left a comment
There was a problem hiding this comment.
Manually verified: download URL returns 200, and AdwaitaMono Nerd Font Mono is the correct font family name inside the tarball. CI build passes. LGTM — ready to merge once promoted from draft.
hanthor
left a comment
There was a problem hiding this comment.
Switching to AdwaitaMono Nerd Font stays close to upstream GNOME while preserving Nerd Font terminal icons. CI passes, already approved. Approved.
hanthor
left a comment
There was a problem hiding this comment.
Switching to AdwaitaMono Nerd Font stays close to upstream GNOME while preserving Nerd Font terminal icons. CI passes, already approved. Approved.
🤖 Copilot Test ReportBranch: Test Results
NoteThis is the oldest open PR in the queue. The font override change has since been merged separately (see #348 which is at HEAD and also carries
|
|
Closing — superseded by #348 which drops the same monospace font override and is already at HEAD. The actual change here is identical; this branch is 121 commits behind main and has a merge conflict. |



Drops our custom monospace font diff from upstream GNOME by replacing JetBrains Mono with the nerd-fonts-patched build of GNOME's own Adwaita Mono, preserving Nerd Font icon support in terminals.
Changes
Containerfile: Addxzto the Alpine build deps; download and extractAdwaitaMono.tar.xzfrom nerd-fonts v3.4.0 intousr/share/fonts/AdwaitaMono/in the shared system layerzz0-bluefin-modifications.gschema.override: Swapmonospace-font-name:Mono(single-width) variant; size 13 is closer to GNOME defaults than the previous 16.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/ryanoasis/nerd-fonts/releases/tags/v3.4.0/usr/bin/curl curl -fsSL REDACTED(http block)just.systems/usr/bin/curl curl -fsSL https://just.systems/install.sh(dns block)If you need me to access, download, or install something from one of these locations, you can either: