fix: correct label htmlFor attributes in AccountForm (#4010)#4011
Open
ashuverma25 wants to merge 4 commits intoprocessing:developfrom
Open
fix: correct label htmlFor attributes in AccountForm (#4010)#4011ashuverma25 wants to merge 4 commits intoprocessing:developfrom
ashuverma25 wants to merge 4 commits intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
ashuverma25
changed the title
Contributor
|
@ashuverma25 I think you haven't made any changes to this branch yet. Please take your time and make a PR. |
ashuverma25
force-pushed
the
fix-account-form-final
branch
from
09fc98c to
d52912e
Compare
Author
Sorry for the sync issue! I've forced the update to the branch. The htmlFor fixes are now live in the 'Files changed' tab. Thank you for your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing #4010 to provide a clean history. This PR fixes the accessibility bug in AccountForm.tsx by ensuring htmlFor attributes perfectly match input IDs.
Changes:
Corrected htmlFor to currentPassword and newPassword.
This PR is based on the latest develop branch and contains a single, focused commit.