fix: correct label htmlFor attributes in AccountForm#4010
Closed
ashuverma25 wants to merge 81 commits intoprocessing:developfrom
Closed
fix: correct label htmlFor attributes in AccountForm#4010ashuverma25 wants to merge 81 commits intoprocessing:developfrom
ashuverma25 wants to merge 81 commits intoprocessing:developfrom
Conversation
…ersion-hint-file Editor file splitting: create new hint file
…ersion-utils-tidy Moves the tidier code and file mode utils out of editor file
I'm fairly certain that we can remove ```
if (!prevProps?.unsavedChanges) {
setTimeout(() => setUnsavedChanges(false), 400);
}
```
I looked at the git blame and it looks like the intention was to stop setting unsavedchanges to false when the files switched, but i think the solve that was implemented 9 years ago did something like "if c == false, c = false" and we should be able to safely remove it instead.
reference commit: processing@77e2f5b
…ersion-splitoff-codemirror Convert Editor to functional, splits off CodeMirror code into its own file
Fix runtime error console
Add tests for tidier.js
…or-v6 Convert tidier.js to TypeScript && test coverage of tidier.ts
Contributor
|
@ashuverma25 Thank you for the PR. It quite hard to review and does not seem well structured. Can you please check it out yourself once. |
Author
@yugalkaushik I have closed this PR and opened a fresh one here: #4011 . This new PR has a clean history with only 1 commit and no conflicts. Sorry for the messy history earlier! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This fixes the accessibility bug reported in #3945. The htmlFor attributes in AccountForm.tsx contained spaces (current password and new password) and did not match the actual input IDs.
I updated the labels to use camelCase (currentPassword and newPassword) to perfectly match the input fields, ensuring screen readers can correctly associate the labels with the inputs.