Skip to content

Fix non-Unix database path compilation #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simolus3 merged 1 commit into from
Jul 30, 2026
Merged

Fix non-Unix database path compilation #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,15 @@ jobs:

- name: Build without rusqlite
run: cargo build --no-default-features

windows:
name: Check Windows build
runs-on: windows-latest
steps:
- uses: actions/checkout@v6

- name: Install stable Rust
run: rustup update stable

- name: Check PowerSync crate
run: cargo check -p powersync --all-targets
4 changes: 3 additions & 1 deletion powersync/src/db/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ fn path_to_cstring(p: &Path) -> Result<CString, PowerSyncError> {

#[cfg(not(unix))]
fn path_to_cstring(p: &Path) -> Result<CString, PowerSyncError> {
let s = p.to_str().ok_or_else(|| Error::InvalidPath(p.to_owned()))?;
let s = p.to_str().ok_or_else(|| RawPowerSyncError::ArgumentError {
desc: format!("Invalid path: {p:?}").into(),
})?;
Ok(
CString::new(s).map_err(|_| RawPowerSyncError::ArgumentError {
desc: format!("Invalid path: {p:?}").into(),
Expand Down
Loading