Skip to content

Fix non-Unix database path compilation - #23

Merged
simolus3 merged 1 commit into
powersync-ja:mainfrom
daniel-vacic:codex/windows-path-build
Jul 30, 2026
Merged

Fix non-Unix database path compilation#23
simolus3 merged 1 commit into
powersync-ja:mainfrom
daniel-vacic:codex/windows-path-build

Conversation

@daniel-vacic

Copy link
Copy Markdown
Contributor

What changed

  • replace the undeclared Error::InvalidPath in the non-Unix path conversion
    with the crate's existing RawPowerSyncError::ArgumentError
  • add a Windows CI job that checks the powersync crate on windows-latest

Root cause

The Windows-only branch was not compiled by the Linux CI job, so the undeclared
type reached main. The implementation now mirrors the Unix branch's error
shape, and CI exercises the actual Windows configuration.

Fixes #20.

Validation

  • rustup run 1.96.0 cargo fmt --all -- --check
  • rustup run 1.96.0 cargo check -p powersync --target x86_64-pc-windows-msvc

The cross-target check now completes successfully from macOS; the added Actions
job will also compile on a native Windows runner.

@daniel-vacic
daniel-vacic marked this pull request as ready for review July 29, 2026 18:24

@simolus3 simolus3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simolus3
simolus3 merged commit fdaaec8 into powersync-ja:main Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-Unix path conversion does not compile (undeclared Error::InvalidPath)

2 participants