Fix non-Unix database path compilation - #23
Merged
simolus3 merged 1 commit intoJul 30, 2026
Conversation
daniel-vacic
marked this pull request as ready for review
July 29, 2026 18:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Error::InvalidPathin the non-Unix path conversionwith the crate's existing
RawPowerSyncError::ArgumentErrorpowersynccrate onwindows-latestRoot cause
The Windows-only branch was not compiled by the Linux CI job, so the undeclared
type reached
main. The implementation now mirrors the Unix branch's errorshape, and CI exercises the actual Windows configuration.
Fixes #20.
Validation
rustup run 1.96.0 cargo fmt --all -- --checkrustup run 1.96.0 cargo check -p powersync --target x86_64-pc-windows-msvcThe cross-target check now completes successfully from macOS; the added Actions
job will also compile on a native Windows runner.