Skip to content

fix: absolute path resolution for directory flag in pull instance #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ishant5436 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

fix: absolute path resolution for directory flag in pull instance #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
def3fca
fix `--directory` absolute path resolution in powersync pull instance…
Ishant5436 Jun 9, 2026
8e91e70
chore: add changeset for directory path fix
Ishant5436 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fix-directory-path.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@powersync/cli-core': patch
'powersync': patch
---

fix `--directory` absolute path resolution in CLI
2 changes: 1 addition & 1 deletion cli/src/commands/pull/instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export default class PullInstance extends CloudInstanceCommand {
orgId: resolvedLink.org_id,
projectId: resolvedLink.project_id
});
this.log(`Created ${ux.colorize('blue', `${directory}/${CLI_FILENAME}`)} with Cloud instance link.`);
this.log(`Created ${ux.colorize('blue', join(projectDir, CLI_FILENAME))} with Cloud instance link.`);
}

const { linked } = await this.loadProject(flags);
Expand Down
4 changes: 2 additions & 2 deletions packages/cli-core/src/command-types/PowerSyncCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { JourneyError } from '@journeyapps-labs/micro-errors';
import { Command, ux } from '@oclif/core';
import { join } from 'node:path';
import { resolve } from 'node:path';

import {
formatPowersyncServiceErrorDisplay,
Expand All @@ -26,7 +26,7 @@ export abstract class PowerSyncCommand extends Command {

/** Resolves the project directory path from the --directory flag (relative to cwd). */
resolveProjectDir(flags: { directory: string }): string {
return join(process.cwd(), flags.directory);
return resolve(process.cwd(), flags.directory);
}

/**
Expand Down