fix: absolute path resolution for directory flag in pull instance#56
fix: absolute path resolution for directory flag in pull instance#56Ishant5436 wants to merge 2 commits into
Conversation
|
|
stevensJourney
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I still have to test this locally, but generally the change seems good to me.
Can you please add a Changeset for this change via pnpm changeset add and also sign the CLA. Thanks!
|
I have read the CLA Document and I hereby sign the CLA |
|
hey @stevensJourney, I already pushed the changeset in a subsequent commit! Let me know if everything looks good on your end when you test locally. Also just left a comment signing the CLA. |
|
Hey @Ishant5436, thanks for taking the time to contribute! We use a tool https://cla-assistant.io to help us manage the CLA signing, and checks will fail until the CLA is signed on that platform specifically. You can sign it using this link (https://cla-assistant.io/powersync-ja/powersync-cli?pullRequest=56) or by clicking the link in the comment left by @CLAassistant. Thanks again! |
--directory absolute path resolution in powersync pull instance
Summary
Fixes an issue where providing an absolute path to the
--directoryflag incorrectly appended the absolute path to the current working directory.Changes
src/utils.ts: updatedresolveProjectDirto usepath.resolvefor proper absolute path resolutionsrc/commands/pull/instance.ts: updated the log message to print the actualprojectDirinstead of the raw flag valueTesting
--directory /absolute/pathresolves correctlyCloses #55