fix: replace deprecated Clock with Timer#429
Open
madisonrickert wants to merge 1 commit intopmndrs:mainfrom
Open
fix: replace deprecated Clock with Timer#429madisonrickert wants to merge 1 commit intopmndrs:mainfrom
madisonrickert wants to merge 1 commit intopmndrs:mainfrom
Conversation
madisonrickert
force-pushed
the
fix/replace-clock-with-timer
branch
from
82b2e8f to
6dcec62
Compare
Port of mrdoob/three.js#32793. THREE.Clock has been deprecated in favor of THREE.Timer, which requires an explicit update() call before reading the delta. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
madisonrickert
force-pushed
the
fix/replace-clock-with-timer
branch
from
6dcec62 to
ac758ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THREE.ClockwithTHREE.TimerinEffectComposerandWater2timer.update()calls beforegetDelta()ClockwithTimer. mrdoob/three.js#32793Test plan
THREE.Clockdeprecation warnings in console🤖 Generated with Claude Code