Skip to content

fix(desktop): restore missing Start Menu shortcut #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsmeares wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −2
Open

fix(desktop): restore missing Start Menu shortcut #7829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions apps/desktop/resources/installer.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
!macro customInstall
!ifndef DO_NOT_CREATE_START_MENU_SHORTCUT
${IfNot} ${FileExists} "$newStartMenuLink"
!insertmacro createMenuDirectory
CreateShortCut "$newStartMenuLink" "$appExe" "" "$appExe" 0 "" "" "${APP_DESCRIPTION}"
ClearErrors
WinShell::SetLnkAUMI "$newStartMenuLink" "${APP_ID}"
${EndIf}
!endif
!macroend
5 changes: 4 additions & 1 deletion scripts/build-desktop-artifact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,10 @@ it.layer(NodeServices.layer)("build-desktop-artifact", (it) => {
},
...WINDOWS_SERVER_EXTRA_RESOURCES,
]);
assert.deepStrictEqual(win.nsis, { differentialPackage: true });
assert.deepStrictEqual(win.nsis, {
differentialPackage: true,
include: "apps/desktop/resources/installer.nsh",
});
// Native binaries and helper executables cannot load from inside an
// asar; everything else stays packed. The Claude SDK platform packages
// and .bin shims never ship.
Expand Down
5 changes: 4 additions & 1 deletion scripts/build-desktop-artifact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,7 +2135,10 @@ export const createBuildConfig = Effect.fn("createBuildConfig")(function* (
// Keep blockmap-based differential downloads enabled while changing the
// installed file topology. The optimization is in the payload shape, not
// in trading update bandwidth for install speed.
buildConfig.nsis = { differentialPackage: true };
buildConfig.nsis = {
differentialPackage: true,
include: "apps/desktop/resources/installer.nsh",
};
const winConfig: Record<string, unknown> = {
target: [target],
icon: "icon.ico",
Expand Down
Loading