Skip to content

fix(desktop): restore missing Start Menu shortcut - #7829

Open
itsmeares wants to merge 1 commit into
pingdotgg:mainfrom
itsmeares:fix/windows-start-menu-shortcut
Open

fix(desktop): restore missing Start Menu shortcut#7829
itsmeares wants to merge 1 commit into
pingdotgg:mainfrom
itsmeares:fix/windows-start-menu-shortcut

Conversation

@itsmeares

@itsmeares itsmeares commented Aug 21, 2026

Copy link
Copy Markdown

Problem

Windows updates preserve the previous shortcut state. If the Start Menu shortcut is missing, later updates and reinstalls keep it missing, leaving the installed app undiscoverable from Windows Search.

Closes #5174.

Fix

Add a small NSIS install hook that recreates the configured Start Menu shortcut only when it is missing, including its AppUserModelID.

Validation

  • Baseline disposable NSIS 26.15.6 fixture: v1 -> missing shortcut -> v2 --updated left the shortcut missing
  • Fixed fixture using this repository's installer.nsh: the same update restored the shortcut with the correct executable target
  • Normal v1 -> v2 update preserved the existing shortcut
  • pnpm exec vp test run scripts/build-desktop-artifact.test.ts -t "applies platform-specific packaging"
  • pnpm exec vp fmt --check scripts/build-desktop-artifact.ts scripts/build-desktop-artifact.test.ts apps/desktop/resources/installer.nsh

Model: GPT-5.6 Sol. Harness: OpenAI desktop agent.

Note

Restore Windows Start Menu shortcut via customInstall NSIS macro

  • Adds a customInstall macro that creates a Start Menu shortcut if it does not already exist and sets its AppUserModelID to the application ID, guarded by DO_NOT_CREATE_START_MENU_SHORTCUT.
  • Updates createBuildConfig in build-desktop-artifact.ts to include the custom installer script in the Windows nsis configuration.
  • Updates the test in build-desktop-artifact.test.ts to verify the nsis config includes the script path.

Macroscope summarized 27486f4.


Note

Low Risk
Installer-only Windows packaging change that recreates a missing Start Menu shortcut; it does not touch auth, data, or app runtime. Existing shortcuts are left unchanged.

Overview
Windows NSIS updates no longer leave a missing Start Menu shortcut missing. A new customInstall hook in installer.nsh recreates the shortcut (with AppUserModelID) only when it is absent, so Search/Start Menu stay usable after reinstalls and updates.

The Windows electron-builder nsis config now includes that script; packaging tests assert the include path.

Reviewed by Cursor Bugbot for commit 27486f4. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 15a09833-4cfe-4305-9e37-1b3f829fe346

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 21, 2026
@itsmeares
itsmeares marked this pull request as ready for review August 21, 2026 17:27
@macroscopeapp

macroscopeapp Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 27486f4

Macroscope's review found this PR approvable — This PR adds standard NSIS installer logic to create a Windows Start Menu shortcut during installation. The change is self-contained to the installer process, doesn't affect runtime application behavior, and includes updated tests.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Windows Start Menu shortcut disappears after Nightly updates

1 participant