Skip to content

Faster IntersectionType->getFiniteTypes() #4746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 3 commits into from
Jan 12, 2026
Merged

Faster IntersectionType->getFiniteTypes() #4746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a29c92
Faster IntersectionType->getFiniteTypes()
staabm Jan 12, 2026
67e58f2
Update IntersectionType.php
staabm Jan 12, 2026
3add726
Update phpstan-baseline.neon
staabm Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,6 +1425,12 @@ parameters:
count: 1
path: src/Type/IntersectionType.php

-
rawMessage: 'Doing instanceof PHPStan\Type\Enum\EnumCaseObjectType is error-prone and deprecated. Use Type::getEnumCases() instead.'
identifier: phpstanApi.instanceofType
count: 1
path: src/Type/IntersectionType.php

-
rawMessage: Doing instanceof PHPStan\Type\IntersectionType is error-prone and deprecated.
identifier: phpstanApi.instanceofType
Expand Down
4 changes: 4 additions & 0 deletions src/Type/IntersectionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,6 +1345,10 @@ public function getFiniteTypes(): array
foreach ($this->types as $type) {
$oneType = [];
foreach ($type->getFiniteTypes() as $finiteType) {
if ($finiteType instanceof EnumCaseObjectType) {
$oneType[$finiteType->getClassName() . '::' . $finiteType->getEnumCaseName()] = $finiteType;
continue;
}
Comment on lines +1348 to +1351
Copy link
Contributor Author

@staabm staabm Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the same type description as in

phpstan-src/src/Type/IntersectionType.php

Line 1027 in 7c5aa63

$oneType[$enumCase->getClassName() . '::' . $enumCase->getEnumCaseName()] = $enumCase;

$oneType[$finiteType->describe(VerbosityLevel::typeOnly())] = $finiteType;
}
$compare[] = $oneType;
Expand Down
Loading