Faster IntersectionType->getFiniteTypes() #4746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This pull request has been marked as ready for review. |
staabm
commented
Jan 12, 2026
Comment on lines
+1348
to
+1351
| if ($finiteType instanceof EnumCaseObjectType) { | ||
| $oneType[$finiteType->getClassName() . '::' . $finiteType->getEnumCaseName()] = $finiteType; | ||
| continue; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
using the same type description as in
phpstan-src/src/Type/IntersectionType.php
Line 1027 in 7c5aa63
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make large enum analysis faster
requires #4744
the repro from phpstan/phpstan#11968
before this PR: 32.32 seconds
after this PR: 8.57 seconds