docs: add full doxygen documentation to get_check_data.hpp - #3125
docs: add full doxygen documentation to get_check_data.hpp#3125withaman69 wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe change expands Doxygen documentation for public helpers in Changesget_check_data documentation
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@include/cpp_common/get_check_data.hpp`:
- Around line 59-65: Update the Doxygen annotation for fetch_column_info to mark
info as [in,out], reflecting that get_column_info modifies each vector element’s
colNumber and type fields through the non-const reference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d91f62ea-edcd-46bc-b52a-0716f009cfec
📒 Files selected for processing (1)
include/cpp_common/get_check_data.hpp
|
Note: the files referenced in issue #972 (get_check_data.c and |
cvvergara
left a comment
There was a problem hiding this comment.
Has many errors
https://github.com/pgRouting/pgrouting/actions/runs/30901475940/job/93109953693?pr=3125#step:10:42
Please fix.
|
Fixed — converted the duplicate Doxygen-style comments in |
Fixes #972 .
Adds complete Doxygen documentation (@PARAM, @throw, @return) to
get_check_data.hpp, matching the detail already present in
get_check_data.cpp. Header docs were previously limited to a single
@brief line per function.
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit