docs: add doxygen documentation to get_points in pgdata_getters.hpp - #3126
docs: add doxygen documentation to get_points in pgdata_getters.hpp#3126withaman69 wants to merge 3 commits into
Conversation
WalkthroughThe PR expands the Changesget_points documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@include/cpp_common/pgdata_getters.hpp`:
- Around line 111-114: Update the get_points declaration to name its const
std::string& parameter sql, matching the existing `@param`[in] sql documentation.
- Around line 106-109: Update the SQL example documented near get_points in
pgdata_getters.hpp by adding a comma between fraction and side, so the SELECT
explicitly returns pid, edge_id, fraction, and side as four columns.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b4bb97e9-ace8-4a35-9eea-4b6d97dd95ef
📒 Files selected for processing (1)
include/cpp_common/pgdata_getters.hpp
Fixes #973
Adds complete Doxygen documentation (@PARAM, @returns, and a usage
example) to get_points() in cpp_common/pgdata_getters.hpp, matching
the detail already present in pgdata_getters.cpp.
Note: points_input.c/.h referenced in the original issue no longer
exist — this functionality now lives in pgdata_getters.hpp/.cpp
alongside 13 other getter functions merged from various now-removed
files. To keep this PR focused, only get_points() is documented here.
Changes proposed in this pull request:
Summary by CodeRabbit
get_pointsdocumentation with a point-query example.