fix(mobile): gate driveto()'s per-step print behind verbose flag#550
Open
petercorke wants to merge 1 commit into
Open
fix(mobile): gate driveto()'s per-step print behind verbose flag#550petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
VehicleDriverBase.driveto() printed an unconditional status line on every call, unlike RandomPath._new_goal() right below it which correctly gates its print behind self._veh.verbose or self._verbose. Any simulation of more than a few steps floods stdout -- found while building a runblock example for docs/source/intro.rst's planned Mobile Robots section. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VehicleDriverBase.driveto()prints an unconditional status line on every call — any simulation longer than a couple of steps floods stdout.RandomPath._new_goal()right below it already gates its print behindself._veh.verbose or self._verbose;driveto()just never got the same treatment. Found while building a working EKF/RandomPath example for a docs update.Test plan
Bicycle+RandomPath) — clean output, no per-step spam🤖 Generated with Claude Code