fix(mobile): guard VehicleDriverBase against workspace=None#541
Open
petercorke wants to merge 1 commit into
Open
fix(mobile): guard VehicleDriverBase against workspace=None#541petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
…omPath docstring example expand_dims(None) raises TypeError despite None being its own advertised default (spatialmath-python bug, tracked in that repo's tech-debt.md), so VehicleDriverBase.__init__ crashed whenever workspace was left unset. Separately, VehicleBase.control's runblock example passed RandomPath(10) positionally, landing in dthresh instead of workspace via **kwargs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VehicleDriverBase.__init__crashed wheneverworkspacewas left at its own default (None), becausespatialmath.base.expand_dims(None)raisesTypeErrordespite advertisingNoneas its default (tracked upstream in spatialmath-python's tech-debt.md).RandomPath(10)passed10positionally intodthresh, notworkspace(which only exists via**kwargs). NowRandomPath(workspace=10).Test plan
RandomPath(workspace=10)construction +print(bike)succeeds end-to-endpytest tests/ -k "mobile or Vehicle or driver"— 25 passed, 1 skipped🤖 Generated with Claude Code