-
Notifications
You must be signed in to change notification settings - Fork 8
feat(advanced): PER-8195 — advanced example for @percy/selenium-webdriver #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shivanshu-07
wants to merge
8
commits into
master
Choose a base branch
from
per-8195-phase-1-selenium-javascript
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1bd9f87
feat(advanced): PER-8195 Phase 1 stub — matrix.yml + README
Shivanshu-07 198cddb
feat(advanced): PER-8195 Phase 1 — add advanced example for @percy/se…
Shivanshu-07 56e702c
fix(ci): run advanced job like the basic job; drop unpublished shared…
Shivanshu-07 e047d4c
fix(advanced): use addArguments('-headless') — Options.headless() was…
Shivanshu-07 aded657
ci: limit GITHUB_TOKEN to read-only permissions (PER-8195)
Shivanshu-07 c30ea88
fix: vendor todomvc CSS locally so advanced snapshots render styled (…
Shivanshu-07 acfd0be
test: raise advanced before-hook timeout to 120s for CI geckodriver p…
Shivanshu-07 d69891e
Merge branch 'master' into per-8195-phase-1-selenium-javascript
Shivanshu-07 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| node_modules/ | ||
| advanced-requests.json | ||
| *.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # PER-8195 — advanced example global config. Demonstrates Percy CLI snapshot | ||
| # config that the @percy/selenium-webdriver SDK consumes as defaults across | ||
| # every snapshot. Per-snapshot options in tests/todomvc_advanced.spec.js | ||
| # override these. | ||
|
|
||
| version: 2 | ||
|
|
||
| snapshot: | ||
| widths: [375, 1280] | ||
| min-height: 1024 | ||
| percy-css: | | ||
| .new-todo::placeholder { color: #999 !important; } | ||
|
|
||
| discovery: | ||
| allowed-hostnames: | ||
| - localhost | ||
| network-idle-timeout: 500 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # Advanced Percy + Selenium-JS example | ||
|
|
||
| This directory exercises the full applicable Percy SDK feature surface for `@percy/selenium-webdriver`. See the basic example at the repo root for the minimum integration. | ||
|
|
||
| ## What this example covers | ||
|
|
||
| A single `mocha` spec (`tests/todomvc_advanced.spec.js`) where each `it(...)` block exercises one row of the [Percy SDK Advanced Feature Matrix](../../../docs/advanced-example-feature-matrix.md). Global SDK config — readiness preset, default widths, discovery — lives in `.percy.yml` and is consumed by every snapshot. | ||
|
|
||
| ## Run locally | ||
|
|
||
| ```bash | ||
| cd advanced | ||
| npm install | ||
| export PERCY_TOKEN="<your project token>" # do NOT commit this | ||
| npm run test:advanced | ||
| ``` | ||
|
|
||
| To run without a real token (CI assertion mode): | ||
|
|
||
| ```bash | ||
| npm run test:advanced:ci # uses --testing + PERCY_TOKEN=fake_token | ||
| ``` | ||
|
|
||
| The CI variant asserts every matrix row appears in the captured POST bodies at the local `/test/requests` endpoint. No real Percy build is created. | ||
|
|
||
| ## Coverage matrix | ||
|
|
||
| States: `Covered` / `N/A — <reason>` / `Planned` / `Deprecated`. Source of truth is [`matrix.yml`](./matrix.yml). | ||
|
|
||
| | Feature | State | Test | | ||
| |---|---|---| | ||
| | widths | Covered | `exercises widths` | | ||
| | minHeight | Covered | `exercises minHeight` | | ||
| | percyCSS | Covered | `exercises percyCSS` | | ||
| | enableJavaScript | Covered | `exercises enableJavaScript` | | ||
| | responsiveSnapshotCapture | Covered | `exercises responsiveSnapshotCapture` | | ||
| | readiness preset | Covered | `exercises readiness preset` | | ||
| | labels | Covered | `exercises labels` | | ||
| | testCase | Covered | `exercises testCase` | | ||
| | devicePixelRatio | Covered | `exercises devicePixelRatio` | | ||
| | regions | Covered | `exercises regions` | | ||
| | browsers override | Covered | `exercises browsers override` | | ||
| | sync mode | Covered | `exercises sync mode` | | ||
| | ignoreCanvasSerializationErrors | Covered | `exercises ignoreCanvasSerializationErrors` | | ||
| | ignoreStyleSheetSerializationErrors | Covered | `exercises ignoreStyleSheetSerializationErrors` | | ||
| | Chrome CDP resize on responsive | Covered | automatic via `@percy/selenium-webdriver >= 2.2.6` | | ||
| | cookie capture via `getCookies` | Covered | automatic via `@percy/selenium-webdriver` | | ||
| | `.percy.yml` global config | Covered | `.percy.yml` consumed at build start | | ||
| | environment info reporting | Covered | automatic via `@percy/selenium-webdriver` client info | | ||
| | PERCY_SERVER_ADDRESS via env | Covered | CI advanced job picks up `PERCY_SERVER_ADDRESS` | | ||
| | `createRegion` helper | Planned | — | | ||
| | `slowScrollToBottom` (lazy loading) | Planned | — | | ||
| | `scope` | N/A | Not exposed in SDK 2.2.6 | | ||
| | `domTransformation` | N/A | Not exposed in SDK 2.2.6 | | ||
| | `discovery` per-snapshot | N/A | discovery is per-build only | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| # PER-8195 Phase 1 — Selenium-JS matrix-row mapping. | ||
| # Test code: tests/todomvc_advanced.spec.js. | ||
|
|
||
| sdk: selenium-javascript | ||
| package: '@percy/selenium-webdriver' | ||
| language: javascript | ||
| sdk_min_version: '2.2.6' | ||
| cli_min_version: '1.31.10' | ||
|
|
||
| rows: | ||
| - id: widths | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises widths' | ||
| - id: min_height | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises minHeight' | ||
| - id: percy_css | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises percyCSS' | ||
| - id: enable_javascript | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises enableJavaScript' | ||
| - id: responsive_snapshot_capture | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises responsiveSnapshotCapture' | ||
| - id: readiness_preset | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises readiness preset' | ||
| - id: labels | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises labels' | ||
| - id: test_case | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises testCase' | ||
| - id: device_pixel_ratio | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises devicePixelRatio' | ||
| - id: regions | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises regions' | ||
| - id: browsers | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises browsers override' | ||
| - id: sync | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises sync mode' | ||
| - id: ignore_canvas_serialization_errors | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises ignoreCanvasSerializationErrors' | ||
| notes: 'No assert-script predicate yet; reported as skip until extended.' | ||
| - id: ignore_stylesheet_serialization_errors | ||
| state: covered | ||
| test: 'TodoMVC Advanced > exercises ignoreStyleSheetSerializationErrors' | ||
| notes: 'No assert-script predicate yet; reported as skip until extended.' | ||
|
|
||
| # Selenium-JS-specific helpers — exposed by SDK but not yet exercised in this | ||
| # phase. | ||
| - id: create_region_helper | ||
| state: planned | ||
| test: 'TodoMVC Advanced > exercises regions (via createRegion helper)' | ||
| - id: slow_scroll_to_bottom_lazy_loading | ||
| state: planned | ||
| test: 'TodoMVC Advanced > exercises slowScrollToBottom helper (PERCY_ENABLE_LAZY_LOADING_SCROLL=true)' | ||
|
|
||
| # Automatic SDK behaviors. | ||
| - id: chrome_cdp_resize | ||
| state: covered | ||
| test: 'automatic via @percy/selenium-webdriver >= 2.2.6 when responsive_snapshot_capture is enabled' | ||
| - id: cookie_capture_via_getcookies | ||
| state: covered | ||
| test: 'automatic via @percy/selenium-webdriver' | ||
|
|
||
| # Options not in the public Selenium-JS surface (per SDK index.d.ts). | ||
| - id: scope | ||
| state: n_a | ||
| reason: 'Not exposed in @percy/selenium-webdriver SnapshotOptions surface as of 2.2.6.' | ||
| - id: dom_transformation | ||
| state: n_a | ||
| reason: 'Not exposed in @percy/selenium-webdriver SnapshotOptions surface as of 2.2.6.' | ||
| - id: discovery | ||
| state: n_a | ||
| reason: 'discovery is per-build, not per-snapshot in this SDK.' | ||
|
|
||
| - id: env_percy_server_address | ||
| state: covered | ||
| test: 'CI: advanced job sets PERCY_SERVER_ADDRESS via env' | ||
| - id: percy_yml_global_config | ||
| state: covered | ||
| test: 'global config consumed via .percy.yml' | ||
| - id: environment_info_reporting | ||
| state: covered | ||
| test: 'automatic via @percy/selenium-webdriver client info' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "name": "example-percy-selenium-javascript-advanced", | ||
| "private": true, | ||
| "description": "Advanced Percy + Selenium-JS example. Exercises the full applicable SDK feature surface. See README.md for the matrix-row coverage.", | ||
| "scripts": { | ||
| "test:advanced": "percy exec -- mocha tests/ --exit", | ||
| "test:advanced:ci": "PERCY_TOKEN=fake_token percy exec --testing -- mocha tests/ --exit" | ||
| }, | ||
| "dependencies": { | ||
| "expect": "^30.2.0", | ||
| "todomvc-app-css": "^2.4.3" | ||
| }, | ||
| "devDependencies": { | ||
| "@percy/cli": "^1.31.13", | ||
| "@percy/selenium-webdriver": "^2.2.6", | ||
| "geckodriver": "^3.0.1", | ||
| "http-server": "^14.1.1", | ||
| "mocha": "^11.7.4", | ||
| "selenium-webdriver": "^4.0.0" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| // PER-8195 Phase 1 — selenium-javascript advanced example. | ||
| // Each test exercises one row of the Advanced Feature Matrix. See ../matrix.yml | ||
| // for the canonical mapping of test name -> matrix row. | ||
|
|
||
| const { Builder, By, Key, until } = require('selenium-webdriver'); | ||
| const firefox = require('selenium-webdriver/firefox'); | ||
| const percySnapshot = require('@percy/selenium-webdriver'); | ||
| const httpServer = require('http-server'); | ||
|
|
||
| const PORT = process.env.PORT_NUMBER || 8003; | ||
| const TEST_URL = `http://localhost:${PORT}`; | ||
|
|
||
| describe('TodoMVC Advanced', function () { | ||
| this.timeout(120000); | ||
| let driver; | ||
| let server; | ||
|
|
||
| before(async () => { | ||
| server = httpServer.createServer({ root: `${__dirname}/../..` }); | ||
| server.listen(PORT); | ||
|
|
||
| const options = new firefox.Options().addArguments('-headless'); | ||
| if (process.env.FIREFOX_BINARY) options.setBinary(process.env.FIREFOX_BINARY); | ||
|
|
||
| driver = await new Builder() | ||
| .forBrowser('firefox') | ||
| .setFirefoxOptions(options) | ||
| .build(); | ||
| }); | ||
|
|
||
| after(async () => { | ||
| if (driver) await driver.quit(); | ||
| if (server) server.close(); | ||
| }); | ||
|
|
||
| beforeEach(async () => { | ||
| await driver.get(TEST_URL); | ||
| await driver.wait(until.titleIs('VanillaJS • TodoMVC'), 5000); | ||
| await driver | ||
| .findElement(By.className('new-todo')) | ||
| .sendKeys('Walk the dog', Key.ENTER); | ||
| }); | ||
|
|
||
| it('exercises widths', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| widths: [375, 768, 1280, 1920], | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises minHeight', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { minHeight: 2000 }); | ||
| }); | ||
|
|
||
| it('exercises percyCSS', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| percyCSS: '.todo-list li { background: #fffde7 !important; }', | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises enableJavaScript', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| enableJavaScript: true, | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises responsiveSnapshotCapture', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| responsiveSnapshotCapture: true, | ||
| widths: [375, 1280], | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises readiness preset', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| readiness: { preset: 'strict', timeoutMs: 5000 }, | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises labels', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| labels: 'smoke,sdk-selenium-js', | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises testCase', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| testCase: 'todomvc-advanced-suite', | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises devicePixelRatio', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { devicePixelRatio: 2 }); | ||
| }); | ||
|
|
||
| it('exercises regions', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| regions: [ | ||
| { | ||
| algorithm: 'ignore', | ||
| elementSelector: { | ||
| boundingBox: { x: 0, y: 0, width: 200, height: 100 }, | ||
| }, | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises browsers override', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| browsers: ['chrome', 'firefox'], | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises sync mode', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { sync: false }); | ||
| }); | ||
|
|
||
| it('exercises ignoreCanvasSerializationErrors', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| ignoreCanvasSerializationErrors: true, | ||
| }); | ||
| }); | ||
|
|
||
| it('exercises ignoreStyleSheetSerializationErrors', async function () { | ||
| await percySnapshot(driver, this.test.fullTitle(), { | ||
| ignoreStyleSheetSerializationErrors: true, | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.