feat(advanced): PER-8195 — advanced example for @percy/selenium-webdriver#17
Open
Shivanshu-07 wants to merge 8 commits into
Open
feat(advanced): PER-8195 — advanced example for @percy/selenium-webdriver#17Shivanshu-07 wants to merge 8 commits into
Shivanshu-07 wants to merge 8 commits into
Conversation
Phase 1 stub for PER-8195 (advanced example for every Percy SDK sample repo). matrix.yml populated from SDK API research, README placeholder notes test code is TO BE WRITTEN. Carries the Phase 0 pattern: per-SDK matrix.yml is the canonical machine-readable source of truth; advanced/README.md table + the aggregate docs/advanced-example-feature-matrix.md grid are generated downstream. No test code committed — needs per-SDK smoke-test validation against the matching SDK toolchain (next step). Most rows currently 'Planned'; some 'Covered' rows reflect behavior automatic via the basic SDK usage (cross-origin iframe handling, cookie capture, environmentInfo). See parent: docs/plans/2026-05-19-001-feat-per-8195-advanced-sdk-examples-plan.md
…lenium-webdriver Adds advanced/ exercising the full applicable @percy/selenium-webdriver SDK feature surface. 14 mocha it() blocks in tests/todomvc_advanced.spec.js, one per matrix row: widths, minHeight, percyCSS, enableJavaScript, responsiveSnapshotCapture, readiness preset, labels, testCase, devicePixelRatio, regions, browsers, sync, ignoreCanvasSerializationErrors, ignoreStyleSheetSerializationErrors. scope, domTransformation, discovery marked N/A — not exposed in @percy/selenium-webdriver 2.2.6 SnapshotOptions surface. CI advanced job uses firefox + geckodriver headless + `percy exec --testing` and asserts via the shared helper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… helper (PER-8195) The advanced job fetched an assertion helper from percy/percy-public-repos-parent/main/scripts/ — that repo is private and the script was never published, so curl -f 404d and failed every advanced run. Master has no --testing mode / matrix-coverage gate; it just runs the spec under percy exec with the repo PERCY_TOKEN. Mirror that: run the advanced suite (which already wraps percy exec) with PERCY_TOKEN, dropping the jq/yq install, the external curl helper, the --testing /test/requests capture, and the matrix assertion. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… removed in selenium-webdriver 4 (PER-8195)
CI's fresh npm install pulls selenium-webdriver 4.36 where firefox.Options().headless() no longer exists (TypeError: .headless is not a function), so the advanced spec never took a snapshot. Use addArguments('-headless'), matching the modern API.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Resolves CodeQL "Workflow does not contain permissions" finding by adding a top-level permissions: contents: read block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amandeepsingh333
previously approved these changes
Jun 9, 2026
…PER-8195) The advanced suite serves the app from its served root, but index.html linked node_modules/todomvc-app-css/index.css which only exists after a repo-root npm install the advanced flow never runs -> CSS 404'd and snapshots rendered unstyled. Vendor index.css beside index.html and point the href at css/index.css (matches java-selenium's existing approach). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amandeepsingh333
previously approved these changes
Jun 11, 2026
…rovisioning (PER-8195) The 45s hook timed out in CI while Selenium Manager provisioned geckodriver. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
advanced/example covering the full applicable@percy/selenium-webdriverSDK feature surface. 14 mochait()blocks intests/todomvc_advanced.spec.js: widths, minHeight, percyCSS, enableJavaScript, responsiveSnapshotCapture, readiness preset, labels, testCase, devicePixelRatio, regions, browsers, sync, ignoreCanvasSerializationErrors, ignoreStyleSheetSerializationErrors.scope,domTransformation,discoverymarkedN/Ain matrix.yml — not exposed in@percy/selenium-webdriver 2.2.6SnapshotOptions surface.Issue: PER-8195.
CI shape
percy exec --testing -- mocha tests/wrapped to capture/test/requests@percy/clipinned to^1.31.13Open question (D8)
Same shared-helper hosting question as the other Phase 1 PRs.
Test plan
advancedCI job to run green.🤖 Generated with Claude Code