[13/n] [meta] migrate BGP config IDs to typed UUIDs#10654
Merged
sunshowers merged 4 commits intoJul 2, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jun 29, 2026
| opctx, | ||
| &bgp_config_id | ||
| .into_untyped_uuid() | ||
| .into(), |
Contributor
There was a problem hiding this comment.
Should we have a From<TypedUuid<T>> for NameOrId? (I don't have strong feelings and don't remember seeing this two-step conversion before now)
Contributor
Author
There was a problem hiding this comment.
Hmm, I'm not sure to be honest! In general I hesitate to suggest From impls due to their potential for magic. But also maybe this one is okay because we're losing information.
Another option is to introduce a separate TypedUuid method/enum variant here, or even add a NameOrTypedUuid<T>.
Contributor
There was a problem hiding this comment.
Yeah, I'm not sure either. I'm fine with just leaving this as-is too; we can always revisit if it starts to pop up more.
sunshowers
changed the base branch from
sunshowers/spr/main.13n-meta-migrate-bgp-config-ids-to-typed-uuids
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/13n-meta-migrate-bgp-config-ids-to-typed-uuids
branch
sunshowers
added a commit
that referenced
this pull request
Jul 2, 2026
Previously, we'd silently pick one of the BGP configs. That seems wrong -- let's reject this situation outright. This is a functional change similar to the earlier one in #10650, where a previously-invalid state was silently accepted and is now rejected. Like in the earlier commits in the stack, I haven't touched the non-bootstore paths in this PR to avoid colliding with other work. But they have the same issue as well where they silently pick one. Depends on: * #10654 * earlier commits in the stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: