[FEATURE REQUEST] Take advantage of the `search_min_length` capability by nero002 · Pull Request #4792 · owncloud/android

nero002 · 2026-03-04T07:33:02Z

Related Issues

App:

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

Description

Make files_sharing.search_min_lenght drive the minimum typed characters required before running user/member searches.
Apply this to file/folder sharing user search and space member search.
Keep the default value at 3 when the capability is not provided.

QA

./gradlew :owncloudComLibrary:testDebugUnitTest --tests "*CapabilityResponseTest" :owncloudDomain:testDebugUnitTest --tests "*OCCapabilityTest"
./gradlew :owncloudApp:compileOriginalDebugKotlin
Manual: verify share/member search starts only after the configured capability threshold.
Manual: verify fallback threshold is 3 when capability is absent.
Manual: verify the new release note item appears in the What's New screen.

CLAassistant · 2026-03-04T07:33:11Z

All committers have signed the CLA.

nero002 · 2026-03-04T07:37:34Z

@jesmrec can you please review

jesmrec · 2026-03-04T13:14:40Z

@nero002 first of all thanks for your contribution. @joragua will review your code and give you feedback and change proposals, after that, i will review it in terms of QA. Keep tuned.

joragua

Good job @nero002! 💯 Some comments here. Let us know if you have any questions about them!

NOTE 1: Just for you to know, we use underscores for the name branch (feature/search_min_lenght_capability). Do not remove the branch, but keep in mind for future PRs 😄

NOTE 2: Be careful with the names. The correct spelling is length, not lenght

joragua · 2026-03-09T11:58:57Z

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt

 class AddMemberFragment: Fragment(), SearchMembersAdapter.SearchMembersAdapterListener {
    private var _binding: AddMemberFragmentBinding? = null
    private val binding get() = _binding!!
+    private val getStoredCapabilitiesUseCase: GetStoredCapabilitiesUseCase by inject()


If you inject a use case directly into the fragment, we are not following the Clean Architecture. In these cases, we use the ViewModels, which contain the methods that execute the use cases.

In this case, if you want to run getStoredCapabilitiesUseCase you would need to use the CapabilityViewModel in the fragment (or create a new method in SpaceMembersViewModel that runs that use case)

private val capabilityViewModel: CapabilityViewModel by viewModel { parametersOf( requireArguments().getString(ARG_ACCOUNT_NAME) ) }

Let us know if you have any questions about the app architecture 😄

joragua · 2026-03-09T12:35:29Z

...oudApp/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt

+            ReleaseNote(
+                title = R.string.release_notes_4_8_0_title_search_minimum_length,
+                subtitle = R.string.release_notes_4_8_0_subtitle_search_minimum_length,
+                type = ReleaseNoteType.ENHANCEMENT
+            ),


Release note not needed in this case 😄

joragua · 2026-03-09T12:38:26Z

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt

+                    if (newText.length >= minimumSearchLength) {
+                        spaceMembersViewModel.searchMembers(newText)
+                    } else {
+                        spaceMembersViewModel.clearSearch()
+                    }


I would not use more than line of code for this block. My suggestion:

if (newText.length >= minimumSearchLength) { spaceMembersViewModel.searchMembers(newText) } else { spaceMembersViewModel.clearSearch() }

joragua · 2026-03-09T12:50:03Z

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt

+    private fun initSearchMinLength() {
+        val accountName = requireArguments().getString(ARG_ACCOUNT_NAME) ?: return
+        minimumSearchLength = getStoredCapabilitiesUseCase(
+            GetStoredCapabilitiesUseCase.Params(accountName = accountName)
+        )?.getFilesSharingSearchMinLength() ?: OCCapability.DEFAULT_FILES_SHARING_SEARCH_MIN_LENGTH
+    }
+


Based on the comment above about Clean Architecture, this method is not longer needed. Instead, you must run the ViewModel method

joragua · 2026-03-09T14:02:11Z

owncloudApp/src/main/java/com/owncloud/android/db/ProviderMeta.java

        public static final String CAPABILITIES_SHARING_PUBLIC_MULTIPLE = "sharing_public_multiple";
        public static final String CAPABILITIES_SHARING_PUBLIC_SUPPORTS_UPLOAD_ONLY = "supports_upload_only";
        public static final String CAPABILITIES_SHARING_RESHARING = "sharing_resharing";
+        public static final String CAPABILITIES_SHARING_SEARCH_MIN_LENGTH = "search_min_length";


Not needed. db/ProviderMeta.java is deprecated as it belongs to the old database

joragua · 2026-03-10T10:19:28Z

...rary/src/main/java/com/owncloud/android/lib/resources/status/responses/CapabilityResponse.kt

+        filesSharingSearchMinLength = capabilities?.fileSharingCapabilities?.fileSharingSearchMinLenght
+            ?: capabilities?.fileSharingCapabilities?.fileSharingSearchMinLength,


Is it OK? The same code appears before and after ?:

capabilities?.fileSharingCapabilities?.fileSharingSearchMinLenght ?: capabilities?.fileSharingCapabilities?.fileSharingSearchMinLength

joragua · 2026-03-10T10:19:36Z

...rary/src/main/java/com/owncloud/android/lib/resources/status/responses/CapabilityResponse.kt

+    @Json(name = "search_min_lenght")
+    val fileSharingSearchMinLenght: Int?,
+    @Json(name = "search_min_length")
+    val fileSharingSearchMinLength: Int?,


Duplicated fields? 🤔

joragua · 2026-03-10T10:28:22Z

.../src/test/java/com/owncloud/android/lib/resources/status/responses/CapabilityResponseTest.kt

Unit tests for response objects are not maintained at this moment in the project. In the future, we will have to discuss about them but right now we only create unit tests for datasources and repositories. So, you can remove this file 😄

joragua · 2026-03-10T10:52:40Z

owncloudDomain/src/main/java/com/owncloud/android/domain/capabilities/model/OCCapability.kt

+    fun getFilesSharingSearchMinLength(): Int =
+        filesSharingSearchMinLength?.takeIf { it > 0 } ?: DEFAULT_FILES_SHARING_SEARCH_MIN_LENGTH
+
+    companion object {
+        const val DEFAULT_FILES_SHARING_SEARCH_MIN_LENGTH = 3
+    }
+


I wouldn't set a default value for filesSharingSearchMinLenght in the model (OCCapability) when it's null, because we are losing some information that comes from the server. Instead, I would handle this in the fragment after observing the capabilities. What do you think?

joragua · 2026-03-10T11:00:06Z

owncloudDomain/src/test/java/com/owncloud/android/domain/capabilities/model/OCCapabilityTest.kt

The same for these tests. We are not maintaining tests for model classes. We have to discuss about them - you can remove the tests from OCCapabilityTest.kt 👍🏻

joragua · 2026-03-10T11:28:52Z

.../main/java/com/owncloud/android/presentation/sharing/sharees/UsersAndGroupsSearchProvider.kt

+        val minSearchLength = capabilities?.getFilesSharingSearchMinLength()
+            ?: OCCapability.DEFAULT_FILES_SHARING_SEARCH_MIN_LENGTH
+
+        if (userQuery.length < minSearchLength) {
+            return MatrixCursor(COLUMNS)
+        }


Could yo try to refactor this? Detekt workflow (link) is failing in the CI system because the method searchUsersAndGroups exceeds 100 lines

nero002 added 2 commits March 4, 2026 13:01

feat: make share search min length capability-driven

54fdc8a

chore: add changelog and release note for search min length

3fead8a

nero002 mentioned this pull request Mar 4, 2026

[FEATURE REQUEST] Take advantage of the search_min_length capability #4789

Open

10 tasks

joragua linked an issue Mar 4, 2026 that may be closed by this pull request

[FEATURE REQUEST] Take advantage of the search_min_length capability #4789

Open

10 tasks

joragua changed the title ~~Enhancement: make share search minimum length capability-driven~~ [FEATURE REQUEST] Take advantage of the search_min_lenght capability Mar 4, 2026

joragua requested changes Mar 10, 2026

View reviewed changes

joragua changed the title ~~[FEATURE REQUEST] Take advantage of the search_min_lenght capability~~ [FEATURE REQUEST] Take advantage of the search_min_lenght capability Mar 10, 2026

joragua changed the title ~~[FEATURE REQUEST] Take advantage of the search_min_lenght capability~~ [FEATURE REQUEST] Take advantage of the search_min_lenght capability Mar 10, 2026

joragua requested changes Mar 10, 2026

View reviewed changes

joragua changed the title ~~[FEATURE REQUEST] Take advantage of the search_min_lenght capability~~ [FEATURE REQUEST] Take advantage of the search_min_length capability Mar 10, 2026

		filesSharingSearchMinLength = capabilities?.fileSharingCapabilities?.fileSharingSearchMinLenght
		?: capabilities?.fileSharingCapabilities?.fileSharingSearchMinLength,

Conversation

nero002 commented Mar 4, 2026

Related Issues

Description

QA

Uh oh!

CLAassistant commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nero002 commented Mar 4, 2026

Uh oh!

jesmrec commented Mar 4, 2026

Uh oh!

joragua left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Mar 4, 2026 •

edited

Loading

joragua left a comment •

edited

Loading