Skip to content

[GR-73856] Ensure synthetic SourceRanges map to unavailable sections. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 2 commits into from
Mar 5, 2026
+3 −2
Merged

[GR-73856] Ensure synthetic SourceRanges map to unavailable sections. #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b44de
Ensure synthetic SourceRanges map to unavailable sections
DSouzaM Mar 4, 2026
12dfa24
Remove accidentally-deleted comment
DSouzaM Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e.graal.python.pegparser/src/com/oracle/graal/python/pegparser/tokenizer/SourceRange.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public SourceRange withEnd(int newEndLine, int newEndColumn) {

public SourceRange startLineShiftColumn(int shift) {
assert shift >= 0;
if (shift == 0) {
if (shift == 0 || this == ARTIFICIAL_RANGE) {
return this;
}
return new SourceRange(startLine, startColumn, startLine, startColumn + shift);
Expand Down
3 changes: 2 additions & 1 deletion ...acle.graal.python/src/com/oracle/graal/python/compiler/bytecode_dsl/RootNodeCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ void beginRootSourceSection(SSTNode node, Builder b) {
}

private static void beginSourceSectionInner(Builder b, SourceRange sourceRange) {
if (sourceRange.startLine >= 1) {
if (sourceRange.startLine >= 1 && sourceRange != SourceRange.ARTIFICIAL_RANGE) {
if (sourceRange.startColumn >= 0 && sourceRange.endLine >= sourceRange.startLine && sourceRange.endColumn >= 0) {
if (sourceRange.endColumn > 0) {
b.beginSourceSection(sourceRange.startLine, sourceRange.startColumn + 1, sourceRange.endLine, sourceRange.endColumn);
Expand Down Expand Up @@ -4120,6 +4120,7 @@ public Void visit(StmtTy.FunctionDef node) {
}

public void emitFunctionDef(StmtTy node, String name, ArgumentsTy args, StmtTy[] body, ExprTy[] decoratorList, ExprTy returns, TypeParamTy[] typeParams) {
// For instrumentation, we want to map this statement only to the declaration line, such
// that, e.g., breakpoints inside the body fire only once the body actually executes and
// not is declared. There is no simple way to get the exact line width here, so we just
// approximate it with name width.
Expand Down
Loading