[GR-73856] Ensure synthetic SourceRanges map to unavailable sections.#669
Merged
graalvmbot merged 2 commits intomasterfrom Mar 5, 2026
Merged
[GR-73856] Ensure synthetic SourceRanges map to unavailable sections.#669graalvmbot merged 2 commits intomasterfrom
graalvmbot merged 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue came up in an insight gate in the Graal repo. When parsed with args (as it is when insight is enabled), Python augments the module AST as:
using
SourceRange.ARTIFICIAL_RANGEfor the injected nodes. These ranges do not map to any meaningful source section, so SourceSection creation can fail. This change mapsSourceRange.ARTIFICIAL_RANGEto an unavailable section.For the "statement" of a function declaration we create a special source range with the length of the function name (using
startLineShiftColumn), which also needs special handling forARTIFICIAL_RANGE.