Skip to content

Fix test timeout #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rasapala merged 1 commit into from
Jun 11, 2026
+8 −17
Merged

Fix test timeout #4285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions src/test/pull_hf_model_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,23 +1907,14 @@ TEST_F(HfDownloadModelModule, TestInvalidProxyTimeout) {
// GIT_OPT_SET_SERVER_CONNECT_TIMEOUT option when https_proxy is empty,
// so we always clear https_proxy here.
//
// To make the timeout actually fire we need the destination to be
// unreachable. The behavior depends on the host's network setup:
// * Host originally used a proxy (https_proxy was set in the
// environment): the host is on a proxy-only network where a
// direct connection to huggingface.co will hang and hit the
// timeout. Keep the default HF_ENDPOINT.
// * Host has no proxy configured (direct internet access): a direct
// connection to huggingface.co would succeed within the 1 s
// timeout and the assertion below would fail. Redirect the clone
// to an unroutable RFC 5737 TEST-NET-1 address so the connect
// must time out.
const char* hostHttpsProxy = std::getenv("https_proxy");
const bool hostHadProxy = (hostHttpsProxy != nullptr) && (std::string(hostHttpsProxy) != "");
// Force deterministic timeout behavior across CI/dev environments.
// Using the real HF endpoint makes this test network-topology dependent
// (proxy-only hosts, direct internet hosts, DNS/load-balancer behavior).
// RFC 5737 TEST-NET-1 (192.0.2.0/24) is non-routable on the public
// internet, so clone must fail quickly and independently of external
// service availability.
eGuard.set("https_proxy", "");
if (!hostHadProxy) {
eGuard.set("HF_ENDPOINT", "https://192.0.2.1/");
}
eGuard.set("HF_ENDPOINT", "https://192.0.2.1/");

@atobiszei atobiszei Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are testing different thing now - inside our CI we have a proper HF_ENDPOINT, and this test was supposed to test if timeout will trigger if we set up proxy wrong.

const std::string timeoutConnectVal = "1000";
eGuard.set(ovms::HfPullModelModule::GIT_SERVER_CONNECT_TIMEOUT_ENV, timeoutConnectVal);
config.parse(arg_count, const_cast<char**>(n_argv));
Expand All @@ -1936,7 +1927,7 @@ TEST_F(HfDownloadModelModule, TestInvalidProxyTimeout) {
timer.stop(0);
double timeSpentMs = timer.elapsed<std::chrono::microseconds>(0) / 1000;
SPDLOG_DEBUG("Time spent:{} ms", timeSpentMs);
EXPECT_LE(timeSpentMs, 3 * ovms::stoi32(timeoutConnectVal).value()) << "We should timeout before 1ms has passed but clone worked for: " << timeSpentMs << "ms > " << timeoutConnectVal << "ms. Status: " << status.string();
EXPECT_LE(timeSpentMs, 3 * ovms::stoi32(timeoutConnectVal).value()) << "We should timeout before 1s has passed but clone worked for: " << timeSpentMs << "ms > " << timeoutConnectVal << "ms. Status: " << status.string();
}
SPDLOG_TRACE("After guard closure");
}
Expand Down