Fix test timeout#4285
Merged
Merged
Conversation
rasapala
requested review from
atobiszei and
Copilot
and removed request for
Copilot
atobiszei
reviewed
Jun 11, 2026
| if (!hostHadProxy) { | ||
| eGuard.set("HF_ENDPOINT", "https://192.0.2.1/"); | ||
| } | ||
| eGuard.set("HF_ENDPOINT", "https://192.0.2.1/"); |
Collaborator
There was a problem hiding this comment.
You are testing different thing now - inside our CI we have a proper HF_ENDPOINT, and this test was supposed to test if timeout will trigger if we set up proxy wrong.
atobiszei
approved these changes
Jun 11, 2026
przepeck
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA CVS-188296
This PR fixes flakiness in TestInvalidProxyTimeout by removing dependency on external network topology.
Previously, the test used conditional logic based on host proxy settings and could still target the real Hugging Face endpoint, causing non-deterministic timing failures across environments.
The test now always clears https_proxy and forces HF_ENDPOINT to https://192.0.2.1/ (RFC 5737 TEST-NET-1, non-routable), ensuring clone failure is deterministic and the timeout path is consistently exercised.
Also corrected the assertion message from “1ms” to “1s” to match the configured timeout value (1000 ms).
🧪 Checklist
``