ROSAENG-60110: Standardize ROSA Prow job naming with environment#80936
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dustman9000: This pull request references ROSAENG-60110 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughTwo CI config files for ROSA e2e tests ( ChangesROSA e2e staging identifier rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
dustman9000
force-pushed
the
rosaeng-60110/standardize-job-naming
branch
from
b8be8d1 to
f0951d3
Compare
|
You need to ensure in the FVT ones that the target job invoked is correct: Where the naming is aligned there, otherwise the prow job may fail to invoke the ocm-backend-test job. It's a technical debt, I'm fine with the rename but it requires first to adjust in the ocm-backend-test repo and then propagate the dependency in prow config. |
|
Good catch, thanks Lucas. Created the upstream MR to rename the job names in ocm-backend-tests first: https://gitlab.cee.redhat.com/service/ocm-backend-tests/-/merge_requests/1963 This PR should merge after that MR lands. |
dustman9000
force-pushed
the
rosaeng-60110/standardize-job-naming
branch
from
f0951d3 to
fc20c46
Compare
Add 'staging' to rosa-e2e nightly and upgrade job names so they consistently indicate which OCM environment they target. This aligns with the FVT jobs which already include staging/integration in their names. Nightly periodics: rosa-hcp-e2e-stable-4-22 -> rosa-hcp-e2e-staging-stable-4-22 Upgrades: rosa-hcp-upgrade-4-20-to-4-21 -> rosa-hcp-upgrade-staging-4-20-to-4-21 FVT jobs are unchanged (already have staging/integration/production). Jira: https://redhat.atlassian.net/browse/ROSAENG-60110
dustman9000
force-pushed
the
rosaeng-60110/standardize-job-naming
branch
from
fc20c46 to
d86de92
Compare
Update rosa-e2e nightly and upgrade job names to include 'staging' and add environment labels to category names for clearer daily Slack reporting. Depends on: openshift/release#80936
|
@dustman9000: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
To reduce churn, we will stick to the long-form env names for now. I've updated this PR to just update the non-FVT job names. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000, jfrazierRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Update rosa-e2e nightly and upgrade job names to include 'staging' and add environment labels to category names for clearer daily Slack reporting. Depends on: openshift/release#80936
Update rosa-e2e nightly and upgrade job names to include 'staging' and add environment labels to category names for clearer daily Slack reporting. Depends on: openshift/release#80936
Update rosa-e2e nightly and upgrade job names to include 'staging' and add environment labels to category names for clearer daily Slack reporting. Depends on: openshift/release#80936
Update rosa-e2e nightly and upgrade job names to include 'staging' and add environment labels to category names for clearer daily Slack reporting. Depends on: openshift/release#80936
Update rosa-e2e nightly and upgrade job names to include 'staging' and add environment labels to category names for clearer daily Slack reporting. Depends on: openshift/release#80936
4 participants
Summary
Add environment shorthand (stg/int/prd) to all ROSA Prow job names for consistent Sippy categorization and human readability.
rosa-e2e nightlies (20 jobs): insert
stg-before channelrosa-hcp-e2e-stable-4-22->rosa-hcp-e2e-stg-stable-4-22rosa-e2e upgrades (2 jobs): insert
stg-before version rangerosa-hcp-upgrade-4-20-to-4-21->rosa-hcp-upgrade-stg-4-20-to-4-21FVT jobs (36 jobs): rename
staging/integration/productiontostg/int/prdin both config filenames (variants) andas:valuesocm-fvt-rosa-hcp-staging->ocm-fvt-rosa-hcp-stgocm-fvt-periodic-cs-rosa-hcp-ad-staging-main->ocm-fvt-periodic-cs-rosa-hcp-ad-stg-mainJira: https://redhat.atlassian.net/browse/ROSAENG-60110
Summary by CodeRabbit
This pull request standardizes ROSA Prow job naming by adding environment segment notation to improve consistency in Sippy categorization and human readability.
Changes Made
ROSA e2e nightly jobs (
openshift-online-rosa-e2e-main__periodics.yaml)Updated 20 periodic test job names by inserting the
stagingsegment into their Argo workflow identifiers. This affects:Example:
rosa-hcp-e2e-stable-4-19→rosa-hcp-e2e-staging-stable-4-19ROSA e2e upgrade jobs (
openshift-online-rosa-e2e-main__upgrade.yaml)Updated 2 upgrade test job names to include the
stagingenvironment segment:rosa-classic-sts-upgrade-4-20-to-4-21→rosa-classic-sts-upgrade-staging-4-20-to-4-21rosa-hcp-upgrade-4-20-to-4-21→rosa-hcp-upgrade-staging-4-20-to-4-21All other job configuration fields (cron schedules, environment variables, workflow references, etc.) remain unchanged. The modifications are surgical, affecting only the Argo workflow naming identifiers used for test categorization and reporting.
Dependencies & Considerations
This change has an upstream dependency: related FVT job names in the ocm-backend-tests repository must be aligned before this PR merges. An upstream merge request (MR 1963) has been created to coordinate these changes across the two repositories.