Skip to content

ROSAENG-60110: Update ROSA regexps for stg/int job naming#3673

Closed
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60110/update-sippy-regexps
Closed

ROSAENG-60110: Update ROSA regexps for stg/int job naming#3673
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60110/update-sippy-regexps

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Update rosa-stage and rosa-integration regexp patterns to match the new shorthand environment naming (stg/int/prd) from the openshift/release job rename.

Depends on: openshift/release#80936

Jira: https://redhat.atlassian.net/browse/ROSAENG-60110

Summary by CodeRabbit

  • Chores
    • Updated test job naming patterns for ROSA e2e staging and integration environments to use standardized naming conventions (-stg- for staging, -int- for integration), improving consistency across managed service validation, upgrade nightlies, and OCM FVT test patterns.

Update rosa-stage and rosa-integration regexp patterns to match
the new shorthand environment naming (stg/int/prd) from the
openshift/release job rename.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 23, 2026

Copy link
Copy Markdown

@dustman9000: This pull request references ROSAENG-60110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Update rosa-stage and rosa-integration regexp patterns to match the new shorthand environment naming (stg/int/prd) from the openshift/release job rename.

Depends on: openshift/release#80936

Jira: https://redhat.atlassian.net/browse/ROSAENG-60110

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7a2895a4-5fae-4530-918d-5447d918fb18

📥 Commits

Reviewing files that changed from the base of the PR and between f3ca81d and 172ea65.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml

Walkthrough

In config/openshift-customizations.yaml, ROSA Presubmits regexp entries are updated: staging-related patterns (managed service validation, upgrade nightlies, OCM FVT) are changed to use -stg- instead of -staging-, and the OCM FVT integration pattern is changed from -integration- to -int-.

Changes

ROSA Presubmits regexp pattern refinements

Layer / File(s) Summary
Staging and integration regexp updates
config/openshift-customizations.yaml
Staging nightly patterns updated to use -stg- naming (comments and regexps); OCM FVT staging pattern switched from -staging- to -stg-; OCM FVT integration pattern narrowed from -integration- to -int-.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • openshift/sippy#3666: Modifies the same config/openshift-customizations.yaml file to split and repopulate rosa-stage vs rosa-integration job regexes, directly related to the same Presubmits regexp selectors being refined here.

Suggested labels

ready-for-human-review

Suggested reviewers

  • smg247
  • deads2k
🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically summarizes the main change: updating ROSA regexp patterns for staging/integration job naming conventions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed PR modifies only YAML configuration file (config/openshift-customizations.yaml) to update ROSA job regexp patterns. Go error handling check is not applicable to configuration-only changes.
Sql Injection Prevention ✅ Passed PR only updates YAML configuration file for ROSA job naming patterns (stg/int shorthand); no SQL code, queries, or database-related changes present - check is not applicable.
Excessive Css In React Should Use Styles ✅ Passed The custom check for React CSS styling is not applicable to this PR. This PR modifies only YAML configuration files (config/openshift-customizations.yaml) to update ROSA job regexp patterns; it con...
Test Coverage For New Features ✅ Passed PR contains only configuration-only changes to openshift-customizations.yaml updating ROSA regexp patterns. This falls under the test coverage check exception for "configuration-only changes" with...
Single Responsibility And Clear Naming ✅ Passed The PR only modifies a YAML configuration file (regexp patterns in config/openshift-customizations.yaml), not any code. The "Single Responsibility and Clear Naming" check applies to code packages,...
Feature Documentation ✅ Passed Configuration-only PR updating ROSA regex patterns; no feature docs apply. Changes are self-documenting with inline YAML comments.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI/CD configuration patterns in config/openshift-customizations.yaml; no Ginkgo test files or test code are changed, so the test names check is not applicable.
Test Structure And Quality ✅ Passed PR contains only config file updates (openshift-customizations.yaml), not Ginkgo test code. The custom check requiring Ginkgo test code review is not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR updates YAML configuration files for Sippy CI tracking tool, not Ginkgo e2e tests. No new test code is added, so MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only updates config/openshift-customizations.yaml regexp patterns for ROSA job naming, not test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only config/openshift-customizations.yaml, a Sippy job configuration file with regex patterns. No deployment manifests, operator code, or scheduling constraints are introduced; check is...
Ote Binary Stdout Contract ✅ Passed PR is not applicable to OTE Binary Stdout Contract: Sippy is a CI analysis tool, not an OTE binary that communicates with openshift-tests via JSON stdout; changes are configuration-only.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. It updates config/openshift-customizations.yaml with regexp patterns and adds standard Go unit/integration tests using the testing package, not Ginkgo, so...
No-Weak-Crypto ✅ Passed PR only modifies YAML configuration file to update job naming patterns; no cryptographic algorithms, custom crypto implementations, or weak crypto usage present.
Container-Privileges ✅ Passed PR only modifies Prow job name patterns in config/openshift-customizations.yaml. No container or K8s manifests with privileged configs found in changes.
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies a YAML configuration file with job name regex patterns; no logging code or sensitive data present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from neisw and sosiouxme June 23, 2026 17:21
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dustman9000
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member Author

Not needed. The regexps from PR #3666 already match the new long-form job names (staging/integration). Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants