Disable rosa-hcp nightly osde2e prow tests

[smarthall]

Summary

• Removes the rosa-hcp test from all four osde2e nightly variants (4.20, 4.21, 4.22, 4.23)
• These tests are now handled by rosa-e2e and are no longer needed

Test plan

• Prow job rehearsal passes
• No rosa-hcp periodic jobs remain in generated config

Jira: https://issues.redhat.com/browse/SREP-4726

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Updated nightly CI test configurations across OpenShift versions 4.20–4.23 by replacing ROSA HCP test entries with ROSA Classic STS test entries
  • Optimized test execution schedules and environment parameters to improve testing workflows and coverage alignment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4349ffba-32c4-4fa4-8ce4-0a4775a7ddf4

📥 Commits

Reviewing files that changed from the base of the PR and between 0fe1b46 and e3dab27.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/osde2e/openshift-osde2e-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (4)

• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.20.yaml
• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.21.yaml
• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.22.yaml
• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.23.yaml

💤 Files with no reviewable changes (4)

• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.20.yaml
• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.23.yaml
• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.21.yaml
• ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.22.yaml

---

Walkthrough

This PR updates CI operator test configurations across four OpenShift osde2e nightly versions (4.20–4.23), replacing rosa-hcp test entries with rosa-classic-sts entries. Three versions update both the test name and environment configuration; version 4.23 removes only the rosa-hcp entry since rosa-classic-sts already exists.

Changes

ROSA Test Configuration Migration

Layer / File(s)	Summary
Test Configuration Replacement (4.20) ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.20.yaml	Replaces rosa-hcp test with rosa-classic-sts, updating CONFIGS from hypershift to rosa,sts,stage,rosa-e2e-suite. Cron schedule remains unchanged.
Test Configuration Replacement (4.21) ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.21.yaml	Replaces rosa-hcp test with rosa-classic-sts, updating CONFIGS from hypershift to rosa,sts,stage,rosa-e2e-suite. Cron adjusted from 10 20 * * * to 10 21 * * *.
Test Configuration Replacement (4.22) ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.22.yaml	Replaces rosa-hcp test with rosa-classic-sts, updating CONFIGS from hypershift to rosa,sts,stage,rosa-e2e-suite. Adds SKIP_DESTROY_CLUSTER: "true" flag. Cron adjusted from 20 20 * * * to 20 4 * * *.
Test Configuration Cleanup (4.23) ci-operator/config/openshift/osde2e/openshift-osde2e-main__nightly-4.23.yaml	Removes rosa-hcp test entry entirely; rosa-classic-sts test already present in this version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the primary change: disabling rosa-hcp nightly osde2e prow tests across all affected configuration files (4.20, 4.21, 4.22, 4.23).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	This check applies to Ginkgo test code. The PR modifies CI operator YAML configuration files, not test code. Job identifiers (rosa-classic-sts) are static configuration keys with no dynamic values.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code quality is not applicable to this PR. The PR modifies only CI configuration YAML files (osde2e nightly test job definitions), not actual test code files.
Microshift Test Compatibility	✅ Passed	PR contains only CI operator configuration changes (YAML files), not new Ginkgo test code. The MicroShift check applies to new test code with Ginkgo patterns, which are absent here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies CI config YAML files to disable rosa-hcp and add rosa-classic-sts configurations. No new Ginkgo test code is added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies CI test job configurations only, not deployment manifests or operator code. Topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract	✅ Passed	OTE Binary Stdout Contract applies to Go test code. This PR exclusively modifies YAML CI configuration files with no Go source code changes. Check is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only YAML CI configuration files, no new Ginkgo e2e test code. Check applies to new Ginkgo test definitions, which are absent. Not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@smarthall: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

[openshift-ci]

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[bmeng]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmeng, smarthall
Once this PR has been reviewed and has the lgtm label, please assign varunraokadaparthi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/osde2e/OWNERS
• ci-operator/jobs/openshift/osde2e/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment