Skip to content

Remove osde2e rosa-hcp nightly job from customizations#3501

Open
smarthall wants to merge 1 commit intoopenshift:mainfrom
smarthall:remove-osde2e-rosa-hcp-nightly
Open

Remove osde2e rosa-hcp nightly job from customizations#3501
smarthall wants to merge 1 commit intoopenshift:mainfrom
smarthall:remove-osde2e-rosa-hcp-nightly

Conversation

@smarthall
Copy link
Copy Markdown
Member

@smarthall smarthall commented May 6, 2026

Summary

Test plan

  • Verify the job no longer appears in the rosa-stage release view

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed a nightly testing job for ROSA HCP 4.21 from the CI/CD pipeline.

The rosa-hcp osde2e nightly tests for 4.20-4.23 were removed in
openshift/release#78884 as they are now handled by rosa-e2e.

Remove the 4.21 rosa-hcp entry from the customizations overlay;
the auto-generated openshift.yaml will pick up the removal on
its next regeneration cycle.

Signed-off-by: Daniel Hall <danhall@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 17c5a49b-e7c0-49e1-910c-bbff01006a55

📥 Commits

Reviewing files that changed from the base of the PR and between 3f4f9ff and 63b3079.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml
💤 Files with no reviewable changes (1)
  • config/openshift-customizations.yaml

Walkthrough

The pull request removes a single ROSA HCP nightly 4.21 job entry from the OpenShift customizations configuration file, reducing the rosa-stage.jobs block by one job declaration.

Changes

ROSA HCP Nightly Job Removal

Layer / File(s) Summary
Job Configuration
config/openshift-customizations.yaml
Removed periodic-ci-openshift-osde2e-main-nightly-4.21-rosa-hcp: true entry from the rosa-stage.jobs block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 17
✅ Passed checks (17 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: removing the osde2e rosa-hcp nightly job from the customizations config file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed The PR only modifies a YAML configuration file (config/openshift-customizations.yaml). The Go Error Handling check is not applicable to non-Go code changes.
Sql Injection Prevention ✅ Passed PR only modifies YAML configuration file with no SQL code or database operations. Change removes a job configuration entry. SQL injection check not applicable to configuration-only changes.
Excessive Css In React Should Use Styles ✅ Passed The custom check for excessive CSS in React is not applicable. This PR modifies only config/openshift-customizations.yaml (a YAML configuration file) and contains no React components or CSS code.
Test Coverage For New Features ✅ Passed This PR is a configuration-only change removing a job entry from config/openshift-customizations.yaml. Per the check exceptions, configuration-only changes do not require test coverage.
Single Responsibility And Clear Naming ✅ Passed PR is a configuration change (removes job from YAML file). The check applies to code design (packages, structs, methods), not configuration files. Not applicable to this PR.
Stable And Deterministic Test Names ✅ Passed Check not applicable: PR contains no Ginkgo test definitions (It, Describe, Context, When). Changes are limited to configuration files and documentation.
Test Structure And Quality ✅ Passed Not applicable. PR modifies only config/openshift-customizations.yaml (removing a job entry). The check applies to Ginkgo test code, which is absent here.
Microshift Test Compatibility ✅ Passed Check not applicable. PR removes a CI job config entry; no new Ginkgo e2e tests are added. The MicroShift compatibility check applies only when new tests are added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only removes a CI job configuration entry and does not add any new Ginkgo e2e tests. The SNO compatibility check applies only to new Ginkgo test code.
Topology-Aware Scheduling Compatibility ✅ Passed This PR only removes a CI job entry from a Prow configuration file. No deployment manifests, operator code, or controllers are modified. The topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed PR modifies only a YAML config file. The OTE stdout contract check applies to executable code, which this PR does not contain.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add any new Ginkgo e2e tests. It only removes a job configuration entry from a YAML file. The custom check applies only to newly added tests, so this PR is not in scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from smg247 and sosiouxme May 6, 2026 05:23
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smarthall
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 6, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant