Skip to content

OCPEDGE-2787: fix: skip MCPs with non-ready nodes during MCN property validation #31380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fracappa wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

OCPEDGE-2787: fix: skip MCPs with non-ready nodes during MCN property validation #31380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/extended/machine_config/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@ func GetRolesToTest(oc *exutil.CLI, machineConfigClient *machineconfigclient.Cli
mcps, mcpErr := machineConfigClient.MachineconfigurationV1().MachineConfigPools().List(context.TODO(), metav1.ListOptions{})
o.Expect(mcpErr).NotTo(o.HaveOccurred(), "Error getting MCPs.")

// For any MCP with machines, add the MCP name as a role to test.
/// For any MCP with machines where all machines are ready, add the MCP name as a role to test.
var rolesToTest []string
for _, mcp := range mcps.Items {
if mcp.Status.MachineCount > 0 {
if mcp.Status.MachineCount > 0 && mcp.Status.ReadyMachineCount == mcp.Status.MachineCount {
rolesToTest = append(rolesToTest, mcp.Name)
}
}
Expand Down