OCPEDGE-2787: fix: skip MCPs with non-ready nodes during MCN property validation#31380
OCPEDGE-2787: fix: skip MCPs with non-ready nodes during MCN property validation#31380fracappa wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@fracappa: This pull request references OCPEDGE-2787 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesMachine configuration readiness
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/extended/machine_config/helpers.go`:
- Around line 137-140: Update the comment above the roles loop to state that the
MCP name is added only for MCPs with machines where all machines are ready,
matching the conditions in the loop over mcps.Items.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 97a85211-de1f-40f9-b3d4-f7f1cd3bf519
📒 Files selected for processing (1)
test/extended/machine_config/helpers.go
In TNA + Day 2 worker upgrade scenarios, the worker MCP has machines but the nod may by in mid-upgrade and not ready yet. The test would fail trying to validate MCN properties on a node that hasn't converged. Only validate pools where all machines are ready.
fracappa
force-pushed
the
fix/skip-updating-mcps-in-mcn-validation
branch
from
04e3552 to
90db000
Compare
openshift-ci
Bot
added
the
ready-for-human-review
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fracappa, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
Scheduling required tests: |
|
@fracappa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
In TNA + Day 2 worker upgrade scenarios, the worker MCP has machines but the nod may by in mid-upgrade and not ready yet. The test would fail trying to validate MCN properties on a node that hasn't converged. Only validate pools where all machines are ready.
Summary by CodeRabbit